You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by er...@apache.org on 2012/02/22 09:52:29 UTC

svn commit: r1292194 - in /james/server/trunk: ./ filesystem-api/ filesystem-api/src/main/java/org/apache/james/filesystem/api/ filesystem-api/src/test/java/org/apache/james/filesystem/api/

Author: eric
Date: Wed Feb 22 08:52:29 2012
New Revision: 1292194

URL: http://svn.apache.org/viewvc?rev=1292194&view=rev
Log:
Integrate SieveFileRepository in server tree - temp solution as a better place must be found, indeed we introduce commons-io in filesystem-api (JSIEVE-86)

Modified:
    james/server/trunk/filesystem-api/pom.xml
    james/server/trunk/filesystem-api/src/main/java/org/apache/james/filesystem/api/SieveFileRepository.java
    james/server/trunk/filesystem-api/src/test/java/org/apache/james/filesystem/api/SieveFileRepositoryTestCase.java
    james/server/trunk/pom.xml

Modified: james/server/trunk/filesystem-api/pom.xml
URL: http://svn.apache.org/viewvc/james/server/trunk/filesystem-api/pom.xml?rev=1292194&r1=1292193&r2=1292194&view=diff
==============================================================================
--- james/server/trunk/filesystem-api/pom.xml (original)
+++ james/server/trunk/filesystem-api/pom.xml Wed Feb 22 08:52:29 2012
@@ -22,19 +22,14 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
     <modelVersion>4.0.0</modelVersion>
-
     <parent>
         <artifactId>james-server</artifactId>
         <groupId>org.apache.james</groupId>
         <version>3.0-beta4-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
-
-    <groupId>org.apache.james</groupId>
     <artifactId>james-server-filesystem-api</artifactId>
-
     <name>Apache James Server Filesystem API</name>
-
     <properties>
         <!-- OSGI stuff -->
         <james.osgi.export>
@@ -44,7 +39,20 @@
             *
         </james.osgi.import>
     </properties>
-
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.james</groupId>
+            <artifactId>apache-jsieve-manager-api</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>commons-io</groupId>
+            <artifactId>commons-io</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+        </dependency>
+    </dependencies>
     <build>
         <plugins>
             <plugin>
@@ -66,6 +74,17 @@
                     </execution>
                 </executions>
             </plugin>
+<!--             TODO Move the SieveFileRepository and SieveFileRepositoryTestCase in other module - See JSIEVE-86 -->
+<!--             Test are exclude (ported from junit 4.x to 3.x) -->
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-surefire-plugin</artifactId>
+              <configuration>
+                <excludes>
+                  <exclude>**/*Test.java</exclude>
+                </excludes>
+              </configuration>
+            </plugin>
         </plugins>
     </build>
 </project>

Modified: james/server/trunk/filesystem-api/src/main/java/org/apache/james/filesystem/api/SieveFileRepository.java
URL: http://svn.apache.org/viewvc/james/server/trunk/filesystem-api/src/main/java/org/apache/james/filesystem/api/SieveFileRepository.java?rev=1292194&r1=1292193&r2=1292194&view=diff
==============================================================================
--- james/server/trunk/filesystem-api/src/main/java/org/apache/james/filesystem/api/SieveFileRepository.java (original)
+++ james/server/trunk/filesystem-api/src/main/java/org/apache/james/filesystem/api/SieveFileRepository.java Wed Feb 22 08:52:29 2012
@@ -18,7 +18,7 @@
  *
  */
 
-package org.apache.james.managesieve.file;
+package org.apache.james.filesystem.api;
 
 import java.io.BufferedOutputStream;
 import java.io.File;
@@ -38,7 +38,6 @@ import javax.annotation.Resource;
 
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.IOUtils;
-import org.apache.james.filesystem.api.FileSystem;
 import org.apache.james.managesieve.api.ConfigurationError;
 import org.apache.james.managesieve.api.DuplicateException;
 import org.apache.james.managesieve.api.DuplicateUserException;

Modified: james/server/trunk/filesystem-api/src/test/java/org/apache/james/filesystem/api/SieveFileRepositoryTestCase.java
URL: http://svn.apache.org/viewvc/james/server/trunk/filesystem-api/src/test/java/org/apache/james/filesystem/api/SieveFileRepositoryTestCase.java?rev=1292194&r1=1292193&r2=1292194&view=diff
==============================================================================
--- james/server/trunk/filesystem-api/src/test/java/org/apache/james/filesystem/api/SieveFileRepositoryTestCase.java (original)
+++ james/server/trunk/filesystem-api/src/test/java/org/apache/james/filesystem/api/SieveFileRepositoryTestCase.java Wed Feb 22 08:52:29 2012
@@ -18,10 +18,7 @@
  *
  */
 
-package org.apache.james.managesieve.file;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+package org.apache.james.filesystem.api;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -30,8 +27,9 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.util.List;
 
+import junit.framework.TestCase;
+
 import org.apache.commons.io.FileUtils;
-import org.apache.james.filesystem.api.FileSystem;
 import org.apache.james.managesieve.api.DuplicateException;
 import org.apache.james.managesieve.api.DuplicateUserException;
 import org.apache.james.managesieve.api.IsActiveException;
@@ -42,14 +40,11 @@ import org.apache.james.managesieve.api.
 import org.apache.james.managesieve.api.SieveRepository;
 import org.apache.james.managesieve.api.StorageException;
 import org.apache.james.managesieve.api.UserNotFoundException;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
 
 /**
  * <code>SieveFileRepositoryTestCase</code>
  */
-public class SieveFileRepositoryTestCase {
+public class SieveFileRepositoryTestCase extends TestCase {
     private static final String SIEVE_ROOT = FileSystem.FILE_PROTOCOL + "sieve";
     
     private FileSystem fs = new FileSystem() {
@@ -72,7 +67,7 @@ public class SieveFileRepositoryTestCase
      *
      * @throws java.lang.Exception
      */
-    @Before
+//    @Before
     public void setUp() throws Exception {
         File root = fs.getFile(SIEVE_ROOT);
         // Remove files from the previous test, if any
@@ -88,7 +83,7 @@ public class SieveFileRepositoryTestCase
      *
      * @throws java.lang.Exception
      */
-    @After
+//    @After
     public void tearDown() throws Exception {
         // Files from the current run are not removed to allow post run analysis
     }
@@ -96,7 +91,7 @@ public class SieveFileRepositoryTestCase
     /**
      * Test method for {@link org.apache.james.managesieve.file.SieveFileRepository#SieveFileRepository(org.apache.james.filesystem.api.FileSystem)}.
      */
-    @Test
+//    @Test
     public final void testSieveFileRepository() {
         SieveRepository repo = new SieveFileRepository(fs);
         assertTrue(repo instanceof SieveRepository);
@@ -113,7 +108,7 @@ public class SieveFileRepositoryTestCase
      * @throws ScriptNotFoundException 
      * @throws FileNotFoundException 
      */
-    @Test
+//    @Test
     public final void testDeleteScript() throws DuplicateUserException, StorageException,
             UserNotFoundException, QuotaExceededException, ScriptNotFoundException,
             IsActiveException, FileNotFoundException {
@@ -158,7 +153,7 @@ public class SieveFileRepositoryTestCase
      * @throws QuotaExceededException 
      * @throws ScriptNotFoundException 
      */
-    @Test
+//    @Test
     public final void testGetScript() throws DuplicateUserException, StorageException, UserNotFoundException, QuotaExceededException, ScriptNotFoundException {
         SieveRepository repo = new SieveFileRepository(fs);
         String user = "test";
@@ -188,7 +183,7 @@ public class SieveFileRepositoryTestCase
      * @throws StorageException 
      * @throws ScriptNotFoundException 
      */
-    @Test
+//    @Test
     public final void testHaveSpace() throws DuplicateUserException, UserNotFoundException, QuotaExceededException, StorageException, ScriptNotFoundException {
         SieveRepository repo = new SieveFileRepository(fs);
         String user = "test";
@@ -255,7 +250,7 @@ public class SieveFileRepositoryTestCase
      * @throws QuotaExceededException 
      * @throws ScriptNotFoundException 
      */
-    @Test
+//    @Test
     public final void testListScripts() throws DuplicateUserException, StorageException, UserNotFoundException, QuotaExceededException, ScriptNotFoundException {
         SieveRepository repo = new SieveFileRepository(fs);
         String user = "test";
@@ -300,7 +295,7 @@ public class SieveFileRepositoryTestCase
      * @throws UserNotFoundException 
      * @throws FileNotFoundException 
      */
-    @Test
+//    @Test
     public final void testPutScript() throws DuplicateUserException, UserNotFoundException,
             StorageException, QuotaExceededException, FileNotFoundException {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -342,7 +337,7 @@ public class SieveFileRepositoryTestCase
      * @throws ScriptNotFoundException 
      * @throws QuotaExceededException 
      */
-    @Test
+//    @Test
     public final void testRenameScript() throws DuplicateUserException, StorageException, UserNotFoundException, IsActiveException, DuplicateException, ScriptNotFoundException, QuotaExceededException {
         SieveRepository repo = new SieveFileRepository(fs);
         String user = "test";
@@ -389,7 +384,7 @@ public class SieveFileRepositoryTestCase
      * @throws UserNotFoundException 
      * @throws ScriptNotFoundException 
      */
-    @Test
+//    @Test
     public final void testGetActive() throws DuplicateUserException, StorageException, UserNotFoundException, QuotaExceededException, ScriptNotFoundException {
         SieveRepository repo = new SieveFileRepository(fs);
         String user = "test";
@@ -429,7 +424,7 @@ public class SieveFileRepositoryTestCase
      * @throws ScriptNotFoundException 
      * @throws QuotaExceededException 
      */
-    @Test
+//    @Test
     public final void testSetActive() throws DuplicateUserException, StorageException,
             UserNotFoundException, ScriptNotFoundException, QuotaExceededException {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -471,7 +466,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(scriptNotFoundExceptionThrown);
     }
     
-    @Test
+//    @Test
     public final void testAddUser() throws DuplicateUserException, StorageException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -481,7 +476,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(repo.hasUser(user));
     }
     
-    @Test
+//    @Test
     public final void testRemoveUser() throws StorageException, DuplicateUserException, UserNotFoundException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -502,7 +497,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(!repo.hasUser(user));
     }
     
-    @Test
+//    @Test
     public final void testHasUser() throws DuplicateUserException, StorageException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -516,7 +511,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(repo.hasUser(user));
     }
     
-    @Test
+//    @Test
     public final void testGetQuota() throws StorageException, QuotaNotFoundException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -535,7 +530,7 @@ public class SieveFileRepositoryTestCase
         assertEquals(Long.MAX_VALUE, repo.getQuota());
     }
     
-    @Test
+//    @Test
     public final void testHasQuota() throws StorageException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -548,7 +543,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(repo.hasQuota());
     }
     
-    @Test
+//    @Test
     public final void testRemoveQuota() throws StorageException, QuotaNotFoundException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -568,7 +563,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(!repo.hasQuota());
     } 
     
-    @Test
+//    @Test
     public final void testSetQuota() throws QuotaNotFoundException, StorageException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -577,7 +572,7 @@ public class SieveFileRepositoryTestCase
         assertEquals(Long.MAX_VALUE, repo.getQuota());   
     }
     
-    @Test
+//    @Test
     public final void testGetUserQuota() throws StorageException, QuotaNotFoundException, DuplicateUserException, UserNotFoundException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -598,7 +593,7 @@ public class SieveFileRepositoryTestCase
         assertEquals(Long.MAX_VALUE, repo.getQuota(user));
     }
     
-    @Test
+//    @Test
     public final void testHasUserQuota() throws StorageException, DuplicateUserException, UserNotFoundException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -613,7 +608,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(repo.hasQuota(user));
     }
     
-    @Test
+//    @Test
     public final void testRemoveUserQuota() throws StorageException, QuotaNotFoundException, DuplicateUserException, UserNotFoundException
     {
         SieveRepository repo = new SieveFileRepository(fs);
@@ -635,7 +630,7 @@ public class SieveFileRepositoryTestCase
         assertTrue(!repo.hasQuota(user));
     } 
     
-    @Test
+//    @Test
     public final void testSetUserQuota() throws QuotaNotFoundException, StorageException, DuplicateUserException, UserNotFoundException
     {
         SieveRepository repo = new SieveFileRepository(fs);

Modified: james/server/trunk/pom.xml
URL: http://svn.apache.org/viewvc/james/server/trunk/pom.xml?rev=1292194&r1=1292193&r2=1292194&view=diff
==============================================================================
--- james/server/trunk/pom.xml (original)
+++ james/server/trunk/pom.xml Wed Feb 22 08:52:29 2012
@@ -607,6 +607,11 @@
                     </exclusion>
                 </exclusions>
             </dependency>
+            <dependency>
+                <groupId>org.apache.james</groupId>
+                <artifactId>apache-jsieve-manager-api</artifactId>
+                <version>${jsieve.version}</version>
+            </dependency>
             <!-- Declare javamail as provided to be able to easily switch -->
             <!-- to different implementations (Geronimo) -->
             <dependency>



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org