You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jemos Infra <je...@googlemail.com> on 2010/06/07 20:17:03 UTC
Moving to TestNG JUnit4?
Hi all,
I haven't received any comments on my suggestion to move to Junit4. I
find that still using Junit3 is ugly, it still relies on inheritance
rather than composition and it doesn't use the potentials of frameworks
such as TestNG (which has the ability of running tests in parallel, plus
many other features). I'm available to do some job, but I'd need
guidance as for the process, since I'm new to this tool from a
development perspective.
Regards,
M.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Moving to TestNG JUnit4?
Posted by Arnaud Héritier <ah...@gmail.com>.
What you can do it is to try to upgrade on a github clone and provide us patch to let us see which impacts it will have on existing code.
It we'll help us in the future to improve our tests and what we can do with them.
But like Jason said it is sure we won't introduce that in trunk for 3.0. It is too dangerous for us now because we rely on them to ensure the quality and the backward compatibility of 3.0 codebase.
Cheers,
Arnaud Héritier
aheritier@apache.org
On Jun 7, 2010, at 8:26 PM, Jason van Zyl wrote:
> We're not changing tests, that's just not a good idea.
>
> New tests we can consider a newer framework and patterns, but we're not switching the old tests. That's not time well spent.
>
> On Jun 7, 2010, at 2:17 PM, Jemos Infra wrote:
>
>> Hi all,
>>
>> I haven't received any comments on my suggestion to move to Junit4. I
>> find that still using Junit3 is ugly, it still relies on inheritance
>> rather than composition and it doesn't use the potentials of frameworks
>> such as TestNG (which has the ability of running tests in parallel, plus
>> many other features). I'm available to do some job, but I'd need
>> guidance as for the process, since I'm new to this tool from a
>> development perspective.
>>
>> Regards,
>>
>> M.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>
> Selfish deeds are the shortest path to self destruction.
>
> -- The Seven Samuari, Akira Kurosawa
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Moving to TestNG JUnit4?
Posted by Jason van Zyl <ja...@sonatype.com>.
We're not changing tests, that's just not a good idea.
New tests we can consider a newer framework and patterns, but we're not switching the old tests. That's not time well spent.
On Jun 7, 2010, at 2:17 PM, Jemos Infra wrote:
> Hi all,
>
> I haven't received any comments on my suggestion to move to Junit4. I
> find that still using Junit3 is ugly, it still relies on inheritance
> rather than composition and it doesn't use the potentials of frameworks
> such as TestNG (which has the ability of running tests in parallel, plus
> many other features). I'm available to do some job, but I'd need
> guidance as for the process, since I'm new to this tool from a
> development perspective.
>
> Regards,
>
> M.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
Selfish deeds are the shortest path to self destruction.
-- The Seven Samuari, Akira Kurosawa
RE: Re : Moving to TestNG JUnit4?
Posted by Martin Gainty <mg...@hotmail.com>.
relates more on how to initialise the operating environment for a Multi-threaded framework such as what is seen here
http://gee.cs.oswego.edu/dl/papers/fj.pdf
if i were to incorporate the multi-thread framework routines into a plugin which would then be used to either exec/yield/sleep/join n number of threads
i would first need to configure the startup parameters for the framework such as groupSize and/or seedValue (for the Fibonacci number)
thanks
Martin Gainty
______________________________________________
Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
> Subject: RE: Re : Moving to TestNG JUnit4?
> Date: Wed, 9 Jun 2010 21:25:35 +0200
> From: Daniel.Siegmann@fja-us.com
> To: dev@maven.apache.org
>
> No, there's no need to "fork" for different unit tests. JUnit 4 will run the old tests just fine, along with the new. All I have done is update my dependency, like so:
>
>
> <dependency>
> <groupId>junit</groupId>
> <artifactId>junit</artifactId>
> <version>4.8.1</version>
> <scope>test</scope>
> </dependency>
>
> Existing tests run, and I can also create and run unit tests using new features (@Test annotation and such).
>
> ~Daniel
>
> -----Original Message-----
> From: Martin Gainty [mailto:mgainty@hotmail.com]
> Sent: Wednesday, June 09, 2010 10:11 AM
> To: dev@maven.apache.org
> Subject: RE: Re : Moving to TestNG JUnit4?
>
>
> Dan and crew
>
> i have seen junit configured as a Resource in the process phase by maven-remote-resources-plugin as in:
>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-remote-resources-plugin</artifactId>
> <executions>
> <execution>
> <goals>
> <goal>process</goal>
> </goals>
> <configuration>
> <resourceBundles>
> <resourceBundle>junit:junit:4.7</resourceBundle>
> </resourceBundles>
> <outputDirectory>${project.build.directory}/${build.finalName}</outputDirectory>
> <attached>false</attached>
> </configuration>
> </execution>
> </executions>
> </plugin>
>
> is this what you are referring or is there an alternate forking mechanism?
>
>
> Martin Gainty
> ______________________________________________
> Jogi és Bizalmassági kinyilatkoztatás/Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
>
>
>
> Ez az üzenet bizalmas. Ha nem ön az akinek szánva volt, akkor kérjük, hogy jelentse azt nekünk vissza. Semmiféle továbbítása vagy másolatának készítése nem megengedett. Ez az üzenet csak ismeret cserét szolgál és semmiféle jogi alkalmazhatósága sincs. Mivel az electronikus üzenetek könnyen megváltoztathatóak, ezért minket semmi felelöség nem terhelhet ezen üzenet tartalma miatt.
>
> Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
> Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
>
>
>
>
>
> > Subject: RE: Re : Moving to TestNG JUnit4?
> > Date: Wed, 9 Jun 2010 15:52:24 +0200
> > From: Daniel.Siegmann@fja-us.com
> > To: dev@maven.apache.org
> >
> > I have similar experience. I upgraded a couple of projects to JUnit 4.8.1 (from 3.x) in the past few months. Leaving the old tests as-is has worked fine, while allowing me to write new tests in the new style, just as you propose.
> >
> > Seems like the best approach to me.
> >
> > ~Daniel Siegmann
> >
> > -----Original Message-----
> > From: Julien HENRY [mailto:henryju@yahoo.fr]
> > Sent: Wednesday, June 09, 2010 8:29 AM
> > To: Maven Developers List
> > Subject: Re : Moving to TestNG JUnit4?
> >
> > > JUnit 4 apparently runs JUnit 3 tests out of the box
> >
> > I can confirm that (starting from JUnit 4.7 if I remember correctly). I usually upgrade all my projects to JUnit 4. This way I can write new tests using JUnit 4 style and keep old tests with JUnit 3 style.
> >
> > My 2 cts
> >
> > ++
> >
> > Julien
> >
> >
> >
> > ----- Message d'origine ----
> > > De : Mark Derricutt <ma...@talios.com>
> > > À : Maven Developers List <de...@maven.apache.org>
> > > Envoyé le : Mer 9 juin 2010, 14h 24min 56s
> > > Objet : Re: Moving to TestNG JUnit4?
> > >
> > > JUnit 4 apparently runs JUnit 3 tests out of the box, so one could
> > > feasibly
> > change the dependencies to JUnit 4 at least. I understand the
> > > reasons for
> > not physically changing old tests for the sake of change
> > > tho.
> >
> > Mark
> >
> > --
> > Pull me down under...
> >
> > On Tue, Jun 8, 2010
> > > at 6:29 AM, Jason Chaffee <
> > > href="mailto:jchaffee@ebates.com">jchaffee@ebates.com> wrote:
> >
> > >
> > > FYI, JUnit now supports concurrent running of tests.
> > >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
> _________________________________________________________________
> Hotmail is redefining busy with tools for the New Busy. Get more from your inbox.
> http://www.windowslive.com/campaign/thenewbusy?ocid=PID28326::T:WLMTAGL:ON:WL:en-US:WM_HMP:042010_2
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
_________________________________________________________________
Hotmail has tools for the New Busy. Search, chat and e-mail from your inbox.
http://www.windowslive.com/campaign/thenewbusy?ocid=PID28326::T:WLMTAGL:ON:WL:en-US:WM_HMP:042010_1
RE: Re : Moving to TestNG JUnit4?
Posted by "Siegmann Daniel, NY" <Da...@fja-us.com>.
No, there's no need to "fork" for different unit tests. JUnit 4 will run the old tests just fine, along with the new. All I have done is update my dependency, like so:
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.8.1</version>
<scope>test</scope>
</dependency>
Existing tests run, and I can also create and run unit tests using new features (@Test annotation and such).
~Daniel
-----Original Message-----
From: Martin Gainty [mailto:mgainty@hotmail.com]
Sent: Wednesday, June 09, 2010 10:11 AM
To: dev@maven.apache.org
Subject: RE: Re : Moving to TestNG JUnit4?
Dan and crew
i have seen junit configured as a Resource in the process phase by maven-remote-resources-plugin as in:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>process</goal>
</goals>
<configuration>
<resourceBundles>
<resourceBundle>junit:junit:4.7</resourceBundle>
</resourceBundles>
<outputDirectory>${project.build.directory}/${build.finalName}</outputDirectory>
<attached>false</attached>
</configuration>
</execution>
</executions>
</plugin>
is this what you are referring or is there an alternate forking mechanism?
Martin Gainty
______________________________________________
Jogi és Bizalmassági kinyilatkoztatás/Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
Ez az üzenet bizalmas. Ha nem ön az akinek szánva volt, akkor kérjük, hogy jelentse azt nekünk vissza. Semmiféle továbbítása vagy másolatának készítése nem megengedett. Ez az üzenet csak ismeret cserét szolgál és semmiféle jogi alkalmazhatósága sincs. Mivel az electronikus üzenetek könnyen megváltoztathatóak, ezért minket semmi felelöség nem terhelhet ezen üzenet tartalma miatt.
Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
> Subject: RE: Re : Moving to TestNG JUnit4?
> Date: Wed, 9 Jun 2010 15:52:24 +0200
> From: Daniel.Siegmann@fja-us.com
> To: dev@maven.apache.org
>
> I have similar experience. I upgraded a couple of projects to JUnit 4.8.1 (from 3.x) in the past few months. Leaving the old tests as-is has worked fine, while allowing me to write new tests in the new style, just as you propose.
>
> Seems like the best approach to me.
>
> ~Daniel Siegmann
>
> -----Original Message-----
> From: Julien HENRY [mailto:henryju@yahoo.fr]
> Sent: Wednesday, June 09, 2010 8:29 AM
> To: Maven Developers List
> Subject: Re : Moving to TestNG JUnit4?
>
> > JUnit 4 apparently runs JUnit 3 tests out of the box
>
> I can confirm that (starting from JUnit 4.7 if I remember correctly). I usually upgrade all my projects to JUnit 4. This way I can write new tests using JUnit 4 style and keep old tests with JUnit 3 style.
>
> My 2 cts
>
> ++
>
> Julien
>
>
>
> ----- Message d'origine ----
> > De : Mark Derricutt <ma...@talios.com>
> > À : Maven Developers List <de...@maven.apache.org>
> > Envoyé le : Mer 9 juin 2010, 14h 24min 56s
> > Objet : Re: Moving to TestNG JUnit4?
> >
> > JUnit 4 apparently runs JUnit 3 tests out of the box, so one could
> > feasibly
> change the dependencies to JUnit 4 at least. I understand the
> > reasons for
> not physically changing old tests for the sake of change
> > tho.
>
> Mark
>
> --
> Pull me down under...
>
> On Tue, Jun 8, 2010
> > at 6:29 AM, Jason Chaffee <
> > href="mailto:jchaffee@ebates.com">jchaffee@ebates.com> wrote:
>
> >
> > FYI, JUnit now supports concurrent running of tests.
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
_________________________________________________________________
Hotmail is redefining busy with tools for the New Busy. Get more from your inbox.
http://www.windowslive.com/campaign/thenewbusy?ocid=PID28326::T:WLMTAGL:ON:WL:en-US:WM_HMP:042010_2
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: Re : Moving to TestNG JUnit4?
Posted by Martin Gainty <mg...@hotmail.com>.
Dan and crew
i have seen junit configured as a Resource in the process phase by maven-remote-resources-plugin as in:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>process</goal>
</goals>
<configuration>
<resourceBundles>
<resourceBundle>junit:junit:4.7</resourceBundle>
</resourceBundles>
<outputDirectory>${project.build.directory}/${build.finalName}</outputDirectory>
<attached>false</attached>
</configuration>
</execution>
</executions>
</plugin>
is this what you are referring or is there an alternate forking mechanism?
Martin Gainty
______________________________________________
Jogi és Bizalmassági kinyilatkoztatás/Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
Ez az üzenet bizalmas. Ha nem ön az akinek szánva volt, akkor kérjük, hogy jelentse azt nekünk vissza. Semmiféle továbbítása vagy másolatának készítése nem megengedett. Ez az üzenet csak ismeret cserét szolgál és semmiféle jogi alkalmazhatósága sincs. Mivel az electronikus üzenetek könnyen megváltoztathatóak, ezért minket semmi felelöség nem terhelhet ezen üzenet tartalma miatt.
Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
> Subject: RE: Re : Moving to TestNG JUnit4?
> Date: Wed, 9 Jun 2010 15:52:24 +0200
> From: Daniel.Siegmann@fja-us.com
> To: dev@maven.apache.org
>
> I have similar experience. I upgraded a couple of projects to JUnit 4.8.1 (from 3.x) in the past few months. Leaving the old tests as-is has worked fine, while allowing me to write new tests in the new style, just as you propose.
>
> Seems like the best approach to me.
>
> ~Daniel Siegmann
>
> -----Original Message-----
> From: Julien HENRY [mailto:henryju@yahoo.fr]
> Sent: Wednesday, June 09, 2010 8:29 AM
> To: Maven Developers List
> Subject: Re : Moving to TestNG JUnit4?
>
> > JUnit 4 apparently runs JUnit 3 tests out of the box
>
> I can confirm that (starting from JUnit 4.7 if I remember correctly). I usually upgrade all my projects to JUnit 4. This way I can write new tests using JUnit 4 style and keep old tests with JUnit 3 style.
>
> My 2 cts
>
> ++
>
> Julien
>
>
>
> ----- Message d'origine ----
> > De : Mark Derricutt <ma...@talios.com>
> > À : Maven Developers List <de...@maven.apache.org>
> > Envoyé le : Mer 9 juin 2010, 14h 24min 56s
> > Objet : Re: Moving to TestNG JUnit4?
> >
> > JUnit 4 apparently runs JUnit 3 tests out of the box, so one could
> > feasibly
> change the dependencies to JUnit 4 at least. I understand the
> > reasons for
> not physically changing old tests for the sake of change
> > tho.
>
> Mark
>
> --
> Pull me down under...
>
> On Tue, Jun 8, 2010
> > at 6:29 AM, Jason Chaffee <
> > href="mailto:jchaffee@ebates.com">jchaffee@ebates.com> wrote:
>
> >
> > FYI, JUnit now supports concurrent running of tests.
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
_________________________________________________________________
Hotmail is redefining busy with tools for the New Busy. Get more from your inbox.
http://www.windowslive.com/campaign/thenewbusy?ocid=PID28326::T:WLMTAGL:ON:WL:en-US:WM_HMP:042010_2
RE: Re : Moving to TestNG JUnit4?
Posted by "Siegmann Daniel, NY" <Da...@fja-us.com>.
I have similar experience. I upgraded a couple of projects to JUnit 4.8.1 (from 3.x) in the past few months. Leaving the old tests as-is has worked fine, while allowing me to write new tests in the new style, just as you propose.
Seems like the best approach to me.
~Daniel Siegmann
-----Original Message-----
From: Julien HENRY [mailto:henryju@yahoo.fr]
Sent: Wednesday, June 09, 2010 8:29 AM
To: Maven Developers List
Subject: Re : Moving to TestNG JUnit4?
> JUnit 4 apparently runs JUnit 3 tests out of the box
I can confirm that (starting from JUnit 4.7 if I remember correctly). I usually upgrade all my projects to JUnit 4. This way I can write new tests using JUnit 4 style and keep old tests with JUnit 3 style.
My 2 cts
++
Julien
----- Message d'origine ----
> De : Mark Derricutt <ma...@talios.com>
> À : Maven Developers List <de...@maven.apache.org>
> Envoyé le : Mer 9 juin 2010, 14h 24min 56s
> Objet : Re: Moving to TestNG JUnit4?
>
> JUnit 4 apparently runs JUnit 3 tests out of the box, so one could
> feasibly
change the dependencies to JUnit 4 at least. I understand the
> reasons for
not physically changing old tests for the sake of change
> tho.
Mark
--
Pull me down under...
On Tue, Jun 8, 2010
> at 6:29 AM, Jason Chaffee <
> href="mailto:jchaffee@ebates.com">jchaffee@ebates.com> wrote:
>
> FYI, JUnit now supports concurrent running of tests.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re : Moving to TestNG JUnit4?
Posted by Julien HENRY <he...@yahoo.fr>.
> JUnit 4 apparently runs JUnit 3 tests out of the box
I can confirm that (starting from JUnit 4.7 if I remember correctly). I usually upgrade all my projects to JUnit 4. This way I can write new tests using JUnit 4 style and keep old tests with JUnit 3 style.
My 2 cts
++
Julien
----- Message d'origine ----
> De : Mark Derricutt <ma...@talios.com>
> À : Maven Developers List <de...@maven.apache.org>
> Envoyé le : Mer 9 juin 2010, 14h 24min 56s
> Objet : Re: Moving to TestNG JUnit4?
>
> JUnit 4 apparently runs JUnit 3 tests out of the box, so one could
> feasibly
change the dependencies to JUnit 4 at least. I understand the
> reasons for
not physically changing old tests for the sake of change
> tho.
Mark
--
Pull me down under...
On Tue, Jun 8, 2010
> at 6:29 AM, Jason Chaffee <
> href="mailto:jchaffee@ebates.com">jchaffee@ebates.com> wrote:
>
> FYI, JUnit now supports concurrent running of tests.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: A legal-ish question
Posted by Jason van Zyl <ja...@sonatype.com>.
You do your coding work, I'll take care of the legal for you. The model of everyone having to check everything is stupid. Code away, if I find a problem we'll yank it.
On Jun 11, 2010, at 7:16 AM, Kristian Rosenvold wrote:
> fr., 11.06.2010 kl. 06.35 -0700, skrev Jason van Zyl:
>> On Jun 10, 2010, at 11:27 PM, Kristian Rosenvold wrote:
>>
>>> I have a memoizer
>>> (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
>>> I'd like to include "somewhere" in our code base. It's like 30 lines of
>>> code or so.
>>>
>>> Ï've seen this snippet of code (or extremely minor permutations of it)
>>> appear a number of places, under various lisence headers, for instance:
>>>
>>> http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
>>>
>>>
>>> What's the appropriate thing to do IP-wise wrt including such a piece of
>>> code ? The specific implementation I've linked to appears on page 108 of
>>> the "Java Concurrency in practice" book.
>>>
>>
>> It's fine, bringing anything up on the legal lists here is a waste of time.
>> will check the code with the folks at Eclipse and let you know if there is any problem.
>> Apache has no IP checking system at all so it's honestly generally useless asking anyone here.
>> Eclipse has a real IP clearance mechanism with real lawyers, with a real set of tools for
>> validation using humans, Black Duck and Palimida. If you've found a public domain license
>> then you're fine, but I'll ask the Eclipse IP team.
>
> Sebb identified the piece of code as "public domain" via the official
> website of the book; I was looking in the hardcopy and couldn't find it
> in the printed book. So much for dead trees.
>
> Now the link Brett sent doesn't explicitly name "Public domain" as a
> "license" with compatibility constraints, but it seems implied in the
> section on Doug Lea's concurrent library:
> http://www.apache.org/legal/resolved.html#concurrent
>
> Kristian
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
Our achievements speak for themselves. What we have to keep track
of are our failures, discouragements and doubts. We tend to forget
the past difficulties, the many false starts, and the painful
groping. We see our past achievements as the end result of a
clean forward thrust, and our present difficulties as
signs of decline and decay.
-- Eric Hoffer, Reflections on the Human Condition
Re: A legal-ish question
Posted by Jesse McConnell <je...@gmail.com>.
imo where ever you drop the code just make it very clear where it came
from, a link to this thread might not hurt to add as well...point
being as others have said it should be perfectly fine for code @ the
ASF but these sorts of things have a way of rearing their ugly head
years down the road and having any sort of documented history of the
code helps immensely.
as painful as it can be to do, this sort of IP tracking is critically
important within code like this
being more involved in the IP process @ eclipse now, I can testify
that Jason is completely correct on the level of detail for IP
validation within Eclipse, its staggering at times.
cheers,
jesse
--
jesse mcconnell
jesse.mcconnell@gmail.com
On Fri, Jun 11, 2010 at 09:16, Kristian Rosenvold
<kr...@gmail.com> wrote:
> fr., 11.06.2010 kl. 06.35 -0700, skrev Jason van Zyl:
>> On Jun 10, 2010, at 11:27 PM, Kristian Rosenvold wrote:
>>
>> > I have a memoizer
>> > (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
>> > I'd like to include "somewhere" in our code base. It's like 30 lines of
>> > code or so.
>> >
>> > Ï've seen this snippet of code (or extremely minor permutations of it)
>> > appear a number of places, under various lisence headers, for instance:
>> >
>> > http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
>> >
>> >
>> > What's the appropriate thing to do IP-wise wrt including such a piece of
>> > code ? The specific implementation I've linked to appears on page 108 of
>> > the "Java Concurrency in practice" book.
>> >
>>
>> It's fine, bringing anything up on the legal lists here is a waste of time.
>> will check the code with the folks at Eclipse and let you know if there is any problem.
>> Apache has no IP checking system at all so it's honestly generally useless asking anyone here.
>> Eclipse has a real IP clearance mechanism with real lawyers, with a real set of tools for
>> validation using humans, Black Duck and Palimida. If you've found a public domain license
>> then you're fine, but I'll ask the Eclipse IP team.
>
> Sebb identified the piece of code as "public domain" via the official
> website of the book; I was looking in the hardcopy and couldn't find it
> in the printed book. So much for dead trees.
>
> Now the link Brett sent doesn't explicitly name "Public domain" as a
> "license" with compatibility constraints, but it seems implied in the
> section on Doug Lea's concurrent library:
> http://www.apache.org/legal/resolved.html#concurrent
>
> Kristian
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: A legal-ish question
Posted by sebb <se...@gmail.com>.
On 11/06/2010, Kristian Rosenvold <kr...@gmail.com> wrote:
> fr., 11.06.2010 kl. 06.35 -0700, skrev Jason van Zyl:
>
> > On Jun 10, 2010, at 11:27 PM, Kristian Rosenvold wrote:
> >
> > > I have a memoizer
> > > (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
> > > I'd like to include "somewhere" in our code base. It's like 30 lines of
> > > code or so.
> > >
> > > Ï've seen this snippet of code (or extremely minor permutations of it)
> > > appear a number of places, under various lisence headers, for instance:
> > >
> > > http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
> > >
> > >
> > > What's the appropriate thing to do IP-wise wrt including such a piece of
> > > code ? The specific implementation I've linked to appears on page 108 of
> > > the "Java Concurrency in practice" book.
> > >
> >
> > It's fine, bringing anything up on the legal lists here is a waste of time.
>
> > will check the code with the folks at Eclipse and let you know if there is any problem.
> > Apache has no IP checking system at all so it's honestly generally useless asking anyone here.
> > Eclipse has a real IP clearance mechanism with real lawyers, with a real set of tools for
> > validation using humans, Black Duck and Palimida. If you've found a public domain license
> > then you're fine, but I'll ask the Eclipse IP team.
>
>
> Sebb identified the piece of code as "public domain" via the official
> website of the book; I was looking in the hardcopy and couldn't find it
> in the printed book. So much for dead trees.
>
> Now the link Brett sent doesn't explicitly name "Public domain" as a
> "license" with compatibility constraints, but it seems implied in the
> section on Doug Lea's concurrent library:
> http://www.apache.org/legal/resolved.html#concurrent
The section at
http://www.apache.org/legal/resolved.html#category-a
includes the link:
"Creative Commons Copyright-Only Dedication"
which links to
http://creativecommons.org/licenses/publicdomain/
i.e. the same as in the
http://www.javaconcurrencyinpractice.com/listings.html
So I think it's clear that the link Brett supplied does apply to ASF
code so long as you use the source from the JCIP site.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: A legal-ish question
Posted by Kristian Rosenvold <kr...@gmail.com>.
fr., 11.06.2010 kl. 06.35 -0700, skrev Jason van Zyl:
> On Jun 10, 2010, at 11:27 PM, Kristian Rosenvold wrote:
>
> > I have a memoizer
> > (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
> > I'd like to include "somewhere" in our code base. It's like 30 lines of
> > code or so.
> >
> > Ï've seen this snippet of code (or extremely minor permutations of it)
> > appear a number of places, under various lisence headers, for instance:
> >
> > http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
> >
> >
> > What's the appropriate thing to do IP-wise wrt including such a piece of
> > code ? The specific implementation I've linked to appears on page 108 of
> > the "Java Concurrency in practice" book.
> >
>
> It's fine, bringing anything up on the legal lists here is a waste of time.
> will check the code with the folks at Eclipse and let you know if there is any problem.
> Apache has no IP checking system at all so it's honestly generally useless asking anyone here.
> Eclipse has a real IP clearance mechanism with real lawyers, with a real set of tools for
> validation using humans, Black Duck and Palimida. If you've found a public domain license
> then you're fine, but I'll ask the Eclipse IP team.
Sebb identified the piece of code as "public domain" via the official
website of the book; I was looking in the hardcopy and couldn't find it
in the printed book. So much for dead trees.
Now the link Brett sent doesn't explicitly name "Public domain" as a
"license" with compatibility constraints, but it seems implied in the
section on Doug Lea's concurrent library:
http://www.apache.org/legal/resolved.html#concurrent
Kristian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: A legal-ish question
Posted by Jason van Zyl <ja...@sonatype.com>.
On Jun 10, 2010, at 11:27 PM, Kristian Rosenvold wrote:
> I have a memoizer
> (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
> I'd like to include "somewhere" in our code base. It's like 30 lines of
> code or so.
>
> Ï've seen this snippet of code (or extremely minor permutations of it)
> appear a number of places, under various lisence headers, for instance:
>
> http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
>
>
> What's the appropriate thing to do IP-wise wrt including such a piece of
> code ? The specific implementation I've linked to appears on page 108 of
> the "Java Concurrency in practice" book.
>
It's fine, bringing anything up on the legal lists here is a waste of time. I will check the code with the folks at Eclipse and let you know if there is any problem. Apache has no IP checking system at all so it's honestly generally useless asking anyone here. Eclipse has a real IP clearance mechanism with real lawyers, with a real set of tools for validation using humans, Black Duck and Palimida. If you've found a public domain license then you're fine, but I'll ask the Eclipse IP team.
> This is a *real hard* piece of code to get right, so I'm not about to
> write my own.
>
> Kristian
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------
Re: A legal-ish question
Posted by sebb <se...@gmail.com>.
On 11/06/2010, Brett Porter <br...@apache.org> wrote:
>
> On 11/06/2010, at 4:27 PM, Kristian Rosenvold wrote:
>
> > I have a memoizer
> > (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
> > I'd like to include "somewhere" in our code base. It's like 30 lines of
> > code or so.
> >
> > Ï've seen this snippet of code (or extremely minor permutations of it)
> > appear a number of places, under various lisence headers, for instance:
> >
> > http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
> >
> >
> > What's the appropriate thing to do IP-wise wrt including such a piece of
> > code ? The specific implementation I've linked to appears on page 108 of
> > the "Java Concurrency in practice" book.
>
>
> It's fine to include it under the terms of it's public domain license:
> http://www.apache.org/legal/resolved.html#category-a
Huh? That does not mention Public Domain?
> - Brett
>
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: A legal-ish question
Posted by Brett Porter <br...@apache.org>.
On 11/06/2010, at 4:27 PM, Kristian Rosenvold wrote:
> I have a memoizer
> (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
> I'd like to include "somewhere" in our code base. It's like 30 lines of
> code or so.
>
> Ï've seen this snippet of code (or extremely minor permutations of it)
> appear a number of places, under various lisence headers, for instance:
>
> http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
>
>
> What's the appropriate thing to do IP-wise wrt including such a piece of
> code ? The specific implementation I've linked to appears on page 108 of
> the "Java Concurrency in practice" book.
It's fine to include it under the terms of it's public domain license:
http://www.apache.org/legal/resolved.html#category-a
- Brett
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: A legal-ish question
Posted by sebb <se...@gmail.com>.
On 11/06/2010, Kristian Rosenvold <kr...@gmail.com> wrote:
> I have a memoizer
> (http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
> I'd like to include "somewhere" in our code base. It's like 30 lines of
> code or so.
>
> Ï've seen this snippet of code (or extremely minor permutations of it)
> appear a number of places, under various lisence headers, for instance:
>
> http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
>
>
> What's the appropriate thing to do IP-wise wrt including such a piece of
> code ? The specific implementation I've linked to appears on page 108 of
> the "Java Concurrency in practice" book.
If you want to include this in ASF code, then IMO this question should
be asked on the ASF legal-discuss list.
Note: the covering description page [1] for the code says
<quote>
Written by Brian Goetz and Tim Peierls with assistance from members of
JCP JSR-166 Expert Group and released to the public domain, as explained at
http://creativecommons.org/licenses/publicdomain
</quote>
> This is a *real hard* piece of code to get right, so I'm not about to
> write my own.
+1 to that!
[1] http://www.javaconcurrencyinpractice.com/listings.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
A legal-ish question
Posted by Kristian Rosenvold <kr...@gmail.com>.
I have a memoizer
(http://www.javaconcurrencyinpractice.com/listings/Memoizer.java) that
I'd like to include "somewhere" in our code base. It's like 30 lines of
code or so.
Ï've seen this snippet of code (or extremely minor permutations of it)
appear a number of places, under various lisence headers, for instance:
http://www.koders.com/java/fid960BDFDD3A35D42E6652E79BA3F959A375024F0B.aspx?s=mdef%3Acompute
What's the appropriate thing to do IP-wise wrt including such a piece of
code ? The specific implementation I've linked to appears on page 108 of
the "Java Concurrency in practice" book.
This is a *real hard* piece of code to get right, so I'm not about to
write my own.
Kristian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Moving to TestNG JUnit4?
Posted by Mark Derricutt <ma...@talios.com>.
JUnit 4 apparently runs JUnit 3 tests out of the box, so one could feasibly
change the dependencies to JUnit 4 at least. I understand the reasons for
not physically changing old tests for the sake of change tho.
Mark
--
Pull me down under...
On Tue, Jun 8, 2010 at 6:29 AM, Jason Chaffee <jc...@ebates.com> wrote:
> FYI, JUnit now supports concurrent running of tests.
>
RE: Moving to TestNG JUnit4?
Posted by Jason Chaffee <jc...@ebates.com>.
FYI, JUnit now supports concurrent running of tests.
http://junit.org/node/589
Jason
-----Original Message-----
From: Jemos Infra [mailto:jemos.infra@googlemail.com]
Sent: Monday, June 07, 2010 11:17 AM
To: Maven-Dev
Subject: Moving to TestNG JUnit4?
Hi all,
I haven't received any comments on my suggestion to move to Junit4. I
find that still using Junit3 is ugly, it still relies on inheritance
rather than composition and it doesn't use the potentials of frameworks
such as TestNG (which has the ability of running tests in parallel, plus
many other features). I'm available to do some job, but I'd need
guidance as for the process, since I'm new to this tool from a
development perspective.
Regards,
M.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org