[GitHub] marcoabreu commented on issue #9329: Add CMake CI build job

[GitBox <gi...@apache.org>]

marcoabreu commented on issue #9329: Add CMake CI build job
URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-357633519
 
 
   From your experience, which build would you expect to break more often and
   is more sensitive to breaking changes? We could move the other one to
   nightly or run both if they are not too time consuming.
   
   Am 15.01.2018 10:45 vorm. schrieb "Pedro Larroy" <no...@github.com>:
   
   > *@larroy* commented on this pull request.
   > ------------------------------
   >
   > In Jenkinsfile
   > <https://github.com/apache/incubator-mxnet/pull/9329#discussion_r161468478>
   > :
   >
   > > @@ -222,6 +243,21 @@ try {
   >          }
   >        }
   >      },
   > +    'CMake': {
   > +      node('mxnetlinux-cpu') {
   > +        ws('workspace/build-cmake-cpu') {
   > +          init_git()
   > +          def defines = """ \
   > +            -DUSE_CUDA=0    \
   >
   > @cjolivier01 <https://github.com/cjolivier01> good point, in my
   > experience a debug build catches more problems than a release build. Of
   > course there are cases where a debug build works and a release one doesn't,
   > those are nasty ones.... Ideally we should run tests in both, but this
   > could be prohibitibely expensive for us.
   >
   > ?
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-mxnet/pull/9329#discussion_r161468478>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/ARxB61UyTxscMWplUCVB_Svgh-OL_CeCks5tKx4jgaJpZM4RVVeD>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services