You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/12/04 16:18:09 UTC

[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #41: Make usage of ninja implementation detail

nanonyme commented on code in PR #41:
URL: https://github.com/apache/buildstream-plugins/pull/41#discussion_r1038995638


##########
src/buildstream_plugins/elements/meson.yaml:
##########
@@ -39,11 +39,11 @@ variables:
 
   meson: meson setup %{conf-root} %{build-dir} %{meson-args}
 
-  ninja: |
+  meson-build: |
     ninja -j ${NINJAJOBS} -C %{build-dir}

Review Comment:
   Good point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org