You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/07/10 09:36:15 UTC
Review Request 12429: Fixed os::sysctl::string to return results with null
bytes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12429/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp a17a3bb68b3434897b59dcf95d71eceddf139b24
Diff: https://reviews.apache.org/r/12429/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 12429: Fixed os::sysctl::string to return results with
null bytes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 15, 2013, 7:47 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp, line 188
> > <https://reviews.apache.org/r/12429/diff/1/?file=319602#file319602line188>
> >
> > What motivated this change?
> >
> > The C++ string constructor will stop at the first null byte encountered.
Some strings might have null bytes. I'll update the comment.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12429/#review23171
-----------------------------------------------------------
On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12429/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:36 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp a17a3bb68b3434897b59dcf95d71eceddf139b24
>
> Diff: https://reviews.apache.org/r/12429/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 12429: Fixed os::sysctl::string to return results with
null bytes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12429/#review23171
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp
<https://reviews.apache.org/r/12429/#comment47031>
What motivated this change?
The C++ string constructor will stop at the first null byte encountered.
- Ben Mahler
On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12429/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:36 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp a17a3bb68b3434897b59dcf95d71eceddf139b24
>
> Diff: https://reviews.apache.org/r/12429/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 12429: Fixed os::sysctl::string to return results with
null bytes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12429/#review23182
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12429/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:36 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp a17a3bb68b3434897b59dcf95d71eceddf139b24
>
> Diff: https://reviews.apache.org/r/12429/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>