You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/12 11:53:43 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3699: sched/task: Remove stack argument from nxtask_init

xiaoxiang781216 commented on pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699#issuecomment-839709958


   > @xiaoxiang781216 - This precludes a statically defined system. It should not brought in.
   
   Here is my thought:
   
   1. All public API task_create/kthread_create/posix_spawn doesn't accept stack pointer as argument
   2. nxtask_init still do the dynamical allocation internally(e.g. task_group...)
   
   If the statical allocation is the target, the public API should accept the stack pointer at least. Do you think it's better to add stackaddr field in posix_a like this:
   ```
   struct posix_spawnattr_s
   {
     FAR void *stackaddr;           
     size_t        stacksize;
   };
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org