[GitHub] [flink] Myasuka commented on a change in pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

[GitBox <gi...@apache.org>]

Myasuka commented on a change in pull request #14614:
URL: https://github.com/apache/flink/pull/14614#discussion_r555641799



##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
##########
@@ -64,6 +71,20 @@
                             "The maximum number of open files (per TaskManager) that can be used by the DB, '-1' means no limit. "
                                     + "RocksDB has default configuration as '-1'.");
 
+    public static final ConfigOption<InfoLogLevel> LOG_LEVEL =
+            key("state.backend.rocksdb.log.level")
+                    .enumType(InfoLogLevel.class)
+                    .noDefaultValue()
+                    .withDescription(String.format(
+                            "The specified log level for DB. Candidate log level is %s, %s, %s, %s, %s or %s, "
+                                    + "and Flink choose '%s' as default style. "

Review comment:
       I think we could remove this line as it add description of `so Flink sets the RocksDB log level to HEADER_LEVEL by default.`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org