[GitHub] [airflow] mis98zb commented on a diff in pull request #32122: control task group concurrency: use allow list for mapping index WIP

["mis98zb (via GitHub)" <gi...@apache.org>]

mis98zb commented on code in PR #32122:
URL: https://github.com/apache/airflow/pull/32122#discussion_r1252501760


##########
airflow/decorators/task_group.py:
##########
@@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) -> _TaskGroupFactory[FParams, FReturn]:
         # TODO: fixme when mypy gets compatible with new attrs
         return attr.evolve(self, partial_kwargs=kwargs)  # type: ignore[arg-type]
 
-    def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:
+    def expand(self, concurrency_limit: int = None, **kwargs: OperatorExpandArgument) -> DAGNode:

Review Comment:
   Got it, I'll move the parameter to partial().
   
   I previously thought about this.
   At that time, my understand is the partial() pass the common parameter to mapped operators, and expand() pass the parameter for expanding.
   So I put the expanding concurrency limitation to expand()...
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org