You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Adam Winer (JIRA)" <ji...@apache.org> on 2008/09/03 02:27:44 UTC
[jira] Created: (SHINDIG-567) Invalid user input should result in
badRequest, not internalError
Invalid user input should result in badRequest, not internalError
-----------------------------------------------------------------
Key: SHINDIG-567
URL: https://issues.apache.org/jira/browse/SHINDIG-567
Project: Shindig
Issue Type: Bug
Components: RESTful API (Java)
Reporter: Adam Winer
Attachments: shindig-567.patch
RequestItem and RpcRequestItem need to treat JSONExceptions, NumberFormatExceptions, and Enum IllegalArgumentExceptions as badRequests; they currently result in internalErrors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-567) Invalid user input should result in
badRequest, not internalError
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated SHINDIG-567:
-------------------------------
Attachment: shindig-567.patch
> Invalid user input should result in badRequest, not internalError
> -----------------------------------------------------------------
>
> Key: SHINDIG-567
> URL: https://issues.apache.org/jira/browse/SHINDIG-567
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Attachments: shindig-567.patch
>
>
> RequestItem and RpcRequestItem need to treat JSONExceptions, NumberFormatExceptions, and Enum IllegalArgumentExceptions as badRequests; they currently result in internalErrors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-567) Invalid user input should result in
badRequest, not internalError
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-567.
----------------------------------
Resolution: Fixed
I reviewed the changes. I weighed this implementation against
* Extending Preconditions by adding a numeric precondition
* Catching IllegalArgumentException and NumberFormatException and generating SocialSpiExceptions at the upper layers
Neither change was compelling enough to replace this particular implementation.
Thanks for the patch!
> Invalid user input should result in badRequest, not internalError
> -----------------------------------------------------------------
>
> Key: SHINDIG-567
> URL: https://issues.apache.org/jira/browse/SHINDIG-567
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Attachments: shindig-567.patch
>
>
> RequestItem and RpcRequestItem need to treat JSONExceptions, NumberFormatExceptions, and Enum IllegalArgumentExceptions as badRequests; they currently result in internalErrors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.