[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #966: [CELEBORN-6] [REFACTOR] PushDataHandler code refactor

[GitBox <gi...@apache.org>]

zhongqiangczq commented on code in PR #966:
URL: https://github.com/apache/incubator-celeborn/pull/966#discussion_r1023469189


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -456,4 +426,44 @@ class PushDataHandler extends BaseMessageHandler with Logging {
   }
 
   override def checkRegistered(): Boolean = registered.get()
+
+  class SimpleRpcResponseCallback(
+      messageType: Message.Type,
+      client: TransportClient,
+      requestId: Long,
+      shuffleKey: String,
+      partitionUniqueId: String)
+    extends RpcResponseCallback {
+    override def onSuccess(response: ByteBuffer): Unit = {
+      client.getChannel.writeAndFlush(new RpcResponse(
+        requestId,
+        new NioManagedBuffer(response)))
+    }
+
+    override def onFailure(e: Throwable): Unit = {
+      logError(
+        s"[process$messageType] Process $messageType onFailure! ShuffleKey:$shuffleKey , partitionUniqueId: $partitionUniqueId",

Review Comment:
   @waitinfuture ,这个地方的messageType的值是PUSH_DATA或者PUSH_MERGE_DATA，而不是之前的PushData或者PushMergeData，这个改动评估一下是否有影响



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org