You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aljoscha Krettek (JIRA)" <ji...@apache.org> on 2018/12/11 12:46:00 UTC

[jira] [Closed] (FLINK-11090) Unused parameter in WindowedStream.aggregate()

     [ https://issues.apache.org/jira/browse/FLINK-11090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aljoscha Krettek closed FLINK-11090.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0

Merged to master in
8c6ff79cbc52f18a8b54a95fa9910858d934658b

> Unused parameter in WindowedStream.aggregate()
> ----------------------------------------------
>
>                 Key: FLINK-11090
>                 URL: https://issues.apache.org/jira/browse/FLINK-11090
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>
> The {{aggregateResultType}} parameter in {{WindowedStream.aggregate()}} seems useless. Or what have I missed?
> If it is useless, I prefer to remove the parameter by adding a new API and deprecate the current one. We can't remove it directly as it is PublicEvolving.
> {code:java}
> 	@PublicEvolving
> 	public <ACC, V, R> SingleOutputStreamOperator<R> aggregate(
> 			AggregateFunction<T, ACC, V> aggregateFunction,
> 			ProcessWindowFunction<V, R, K, W> windowFunction,
> 			TypeInformation<ACC> accumulatorType,
> 			TypeInformation<V> aggregateResultType,
> 			TypeInformation<R> resultType) {
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)