You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/06/01 21:45:23 UTC
Re: Review Request 34529: Add non-const reference version of
Option::get.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review86055
-----------------------------------------------------------
Ship it!
I will get this committed for you, but I'll remove the operators you've added here as it probably warrants more discussion.
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
<https://reviews.apache.org/r/34529/#comment137922>
Let's remove these as we should think about the implications of this, should we really ahve 3 ways to obtain the value?
- Ben Mahler
On May 31, 2015, 4:39 a.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34529/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 4:39 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2716
> https://issues.apache.org/jira/browse/MESOS-2716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add non-const reference version of Option<T>::get.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp ea79b501d9ed7b7da9636ce9c9c590738a586993
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c
>
> Diff: https://reviews.apache.org/r/34529/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>
Re: Review Request 34529: Add non-const reference version of
Option::get.
Posted by Mark Wang <ma...@gmail.com>.
> On June 1, 2015, 7:45 p.m., Ben Mahler wrote:
> > I will get this committed for you, but I'll remove the operators you've added here as it probably warrants more discussion.
OK.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review86055
-----------------------------------------------------------
On May 31, 2015, 4:39 a.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34529/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 4:39 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2716
> https://issues.apache.org/jira/browse/MESOS-2716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add non-const reference version of Option<T>::get.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp ea79b501d9ed7b7da9636ce9c9c590738a586993
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c
>
> Diff: https://reviews.apache.org/r/34529/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>