You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/22 15:46:06 UTC

[GitHub] [incubator-doris] morningman commented on a change in pull request #5114: Add fuzzy_parse option to speed up json import

morningman commented on a change in pull request #5114:
URL: https://github.com/apache/incubator-doris/pull/5114#discussion_r547349233



##########
File path: be/src/exec/json_scanner.cpp
##########
@@ -487,10 +501,6 @@ void JsonReader::_set_tuple_value(rapidjson::Value& objectValue, Tuple* tuple,
 Status JsonReader::_handle_simple_json(Tuple* tuple, const std::vector<SlotDescriptor*>& slot_descs,
                                        MemPool* tuple_pool, bool* eof) {
     // If you use a string as the key to find the json object, strlen will be called every time, so the key is constructed in advance

Review comment:
       This commend can be removed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org