You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2005/06/17 06:08:47 UTC
[jira] Created: (GERONIMO-682) Automatic key generators too restrictive
Automatic key generators too restrictive
----------------------------------------
Key: GERONIMO-682
URL: http://issues.apache.org/jira/browse/GERONIMO-682
Project: Geronimo
Type: Bug
Components: OpenEJB
Versions: 1.0-M3
Reporter: Aaron Mulder
The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-682) Automatic key generators too restrictive
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-682?page=all ]
Aaron Mulder closed GERONIMO-682:
---------------------------------
Fix Version: 1.0-M5
Resolution: Fixed
The AUTO_INCREMENT issue was just a misunderstanding; some of the rest was cleared up in the pkgen module. Opening TranQL issues for anything else.
> Automatic key generators too restrictive
> ----------------------------------------
>
> Key: GERONIMO-682
> URL: http://issues.apache.org/jira/browse/GERONIMO-682
> Project: Geronimo
> Type: Bug
> Components: OpenEJB
> Versions: 1.0-M3
> Reporter: Aaron Mulder
> Fix For: 1.0-M5
>
> The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
> The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
> If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
> The AutoIncrement key generator doesn't seem to handle the case where the PK column of the EJB table itself is set to AUTO_INCREMENT (e.g. MySQL), since it seems to want a SQL statement separate from the EJB insert in order to produce the new ID. Perhaps I just don't understand it correctly, or perhaps this should be a separate enhancement request.
> Also, there's no way to map a DB sequence (Oracle, PostgreSQL) which itself has a batch/increment size (perhaps the SQL automatic key generator should be able to use a batch size like the TableSequence generator can).
> These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-682) Automatic key generators too restrictive
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-682?page=all ]
Aaron Mulder updated GERONIMO-682:
----------------------------------
Description:
The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
Also, there's no way to map a DB sequence (Oracle, PostgreSQL) which itself has a batch/increment size (perhaps the SQL automatic key generator should be able to use a batch size like the TableSequence generator can).
These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
was:
The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
> Automatic key generators too restrictive
> ----------------------------------------
>
> Key: GERONIMO-682
> URL: http://issues.apache.org/jira/browse/GERONIMO-682
> Project: Geronimo
> Type: Bug
> Components: OpenEJB
> Versions: 1.0-M3
> Reporter: Aaron Mulder
>
> The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
> The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
> If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
> Also, there's no way to map a DB sequence (Oracle, PostgreSQL) which itself has a batch/increment size (perhaps the SQL automatic key generator should be able to use a batch size like the TableSequence generator can).
> These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-682) Automatic key generators too restrictive
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-682?page=all ]
Aaron Mulder updated GERONIMO-682:
----------------------------------
Description:
The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
The AutoIncrement key generator doesn't seem to handle the case where the PK column of the EJB table itself is set to AUTO_INCREMENT (e.g. MySQL), since it seems to want a SQL statement separate from the EJB insert in order to produce the new ID. Perhaps I just don't understand it correctly, or perhaps this should be a separate enhancement request.
Also, there's no way to map a DB sequence (Oracle, PostgreSQL) which itself has a batch/increment size (perhaps the SQL automatic key generator should be able to use a batch size like the TableSequence generator can).
These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
was:
The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
Also, there's no way to map a DB sequence (Oracle, PostgreSQL) which itself has a batch/increment size (perhaps the SQL automatic key generator should be able to use a batch size like the TableSequence generator can).
These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
> Automatic key generators too restrictive
> ----------------------------------------
>
> Key: GERONIMO-682
> URL: http://issues.apache.org/jira/browse/GERONIMO-682
> Project: Geronimo
> Type: Bug
> Components: OpenEJB
> Versions: 1.0-M3
> Reporter: Aaron Mulder
>
> The SequenceTable automatic key generator always executes a create table statement, and just ignores any errors. I don't believe this is appropriate -- I suspect in most cases the user is not going to expect/want the app server to create tables (or indeed execute any DDL).
> The SQL automatic key generator requires an initSQL statement that is always executed. Again, I don't feel this is appropriate, since I think it will be much more common for the underlying database sequence (or whatever) to already exist (and as is it will generate a warning on every startup *if your database is configured correctly*).
> If the create/initialize behavior is strongly desired, there should be a flag to enable it (defaulting to false IMHO) and/or this step should be skipped if no initSQL is specified.
> The AutoIncrement key generator doesn't seem to handle the case where the PK column of the EJB table itself is set to AUTO_INCREMENT (e.g. MySQL), since it seems to want a SQL statement separate from the EJB insert in order to produce the new ID. Perhaps I just don't understand it correctly, or perhaps this should be a separate enhancement request.
> Also, there's no way to map a DB sequence (Oracle, PostgreSQL) which itself has a batch/increment size (perhaps the SQL automatic key generator should be able to use a batch size like the TableSequence generator can).
> These appear to actually be TranQL problems, but there's no such category above. See org.tranql.pkgenerator.*
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira