You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2011/12/04 22:33:15 UTC
RE: svn commit: r1210195 - /subversion/trunk/subversion/svnserve/serve.c
> -----Original Message-----
> From: danielsh@apache.org [mailto:danielsh@apache.org]
> Sent: zondag 4 december 2011 21:13
> To: commits@subversion.apache.org
> Subject: svn commit: r1210195 -
> /subversion/trunk/subversion/svnserve/serve.c
>
> Author: danielsh
> Date: Sun Dec 4 20:13:01 2011
> New Revision: 1210195
>
> URL: http://svn.apache.org/viewvc?rev=1210195&view=rev
> Log:
> Canonicalize svnserve.conf input.
Maybe you should apply svn_dirent_internal_style() instead of just canonicalize to catch '\' vs '/' on Windows.
Bert
>
> Found by: Justin Finkelstein <ju...@redwiredesign.com>
>
> * subversion/svnserve/serve.c
> (load_configs): Canonicalize password-db and authz-db paths.
Re: svn commit: r1210195 -
/subversion/trunk/subversion/svnserve/serve.c
Posted by Daniel Shahaf <da...@elego.de>.
Bert Huijben wrote on Sun, Dec 04, 2011 at 22:33:15 +0100:
>
>
> > -----Original Message-----
> > From: danielsh@apache.org [mailto:danielsh@apache.org]
> > Sent: zondag 4 december 2011 21:13
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1210195 -
> > /subversion/trunk/subversion/svnserve/serve.c
> >
> > Author: danielsh
> > Date: Sun Dec 4 20:13:01 2011
> > New Revision: 1210195
> >
> > URL: http://svn.apache.org/viewvc?rev=1210195&view=rev
> > Log:
> > Canonicalize svnserve.conf input.
>
> Maybe you should apply svn_dirent_internal_style() instead of just
> canonicalize to catch '\' vs '/' on Windows.
If you think that's better I can make the change. I'm not terribly well
familiar with the Windows-specific semantics of svn_dirent_canonicalize()
as compared to svn_dirent_internal_style().