You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Horatiu Lazu (JIRA)" <ji...@apache.org> on 2018/02/02 00:21:00 UTC
[jira] [Updated] (LUCENE-8151) Redundant conditionals in JoinUtil
[ https://issues.apache.org/jira/browse/LUCENE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Horatiu Lazu updated LUCENE-8151:
---------------------------------
Attachment: LUCENE-8151.patch
> Redundant conditionals in JoinUtil
> ----------------------------------
>
> Key: LUCENE-8151
> URL: https://issues.apache.org/jira/browse/LUCENE-8151
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Horatiu Lazu
> Priority: Trivial
> Attachments: LUCENE-8151.patch
>
>
> JoinUtil has a strange conditional structure, which can be collapsed under one function call:
> On line 200:
> {code:java}
> @Override
> public void collect(int doc) throws IOException {
> if (doc > sortedNumericDocValues.docID()) {
> sortedNumericDocValues.advance(doc);
> }
> if (doc == sortedNumericDocValues.docID()) {
> for (int i = 0; i < sortedNumericDocValues.docValueCount(); i++) {
> long value = sortedNumericDocValues.nextValue();
> joinValues.add(value);
> if (needsScore) {
> scoreAggregator.accept(value, scorer.score());
> }
> }
> }
> }{code}
> Instead, just do advanceExact, which returns a boolean indicating if it was successful:
> {code:java}
> @Override
> public void collect(int doc) throws IOException {
> if (sortedNumericDocValues.advanceExact(doc)) {
> for (int i = 0; i < sortedNumericDocValues.docValueCount(); i++) {
> long value = sortedNumericDocValues.nextValue();
> joinValues.add(value);
> if (needsScore) {
> scoreAggregator.accept(value, scorer.score());
> }
> }
> }
> }
> {code}
> I have the patch ready, it passes unit tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org