You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/21 13:22:03 UTC
[GitHub] [superset] yeachan153 opened a new issue, #21909: Results/Samples tab in charts causes identical query to run twice in backend
yeachan153 opened a new issue, #21909:
URL: https://github.com/apache/superset/issues/21909
Having the results/samples tab open while creating a chart results in the same query run twice by the backend.
#### How to reproduce the bug
1. Go to charts
2. Create a chart, ensuring that the results/samples tab is active
3. Update the chart
The backend should show the same query being run twice, once for the chart and once for the results/samples tab. Minimising the results/samples tab and updating the chart only causes the query to be run once.
### Expected results
Execute the same query once and share the result between the charts section and the results/samples tab.
### Actual results
The same query gets run twice, it seems like the results/samples tab is being treated as a separate chart.
### Environment
- browser type and version: `Chrome (106.0.5249.119)`
- superset version: `2.0.0`
- python version: `3.8.12`
- backend: `spark 3.2.0`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Results/Samples tab in charts causes identical query to run twice in backend [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #21909: Results/Samples tab in charts causes identical query to run twice in backend
URL: https://github.com/apache/superset/issues/21909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Results/Samples tab in charts causes identical query to run twice in backend [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #21909:
URL: https://github.com/apache/superset/issues/21909#issuecomment-1942164023
The `full` and `results` queries are _similar_ but may be of vastly different sizes, and have different caching treatments. This is by design, so I'm closing this as a bug, but we're open to proposals/PRs/discussions if you want to contribute any enhancements here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #21909: Results/Samples tab in charts causes identical query to run twice in backend
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #21909:
URL: https://github.com/apache/superset/issues/21909#issuecomment-1288477520
@yeachan153 the request of the `visualization` and request of the `results tab` is different *result_type* in the request payload, the one is `full`, the other is `results`
The `DATAPANEL_CLOSED_BY_DEFAULT` in the FEATURE_FLAG is able to close the data panel by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yeachan153 commented on issue #21909: Results/Samples tab in charts causes identical query to run twice in backend
Posted by GitBox <gi...@apache.org>.
yeachan153 commented on issue #21909:
URL: https://github.com/apache/superset/issues/21909#issuecomment-1298253490
@zhaoyongjie thanks for taking a look. The query that ran in the backed was identical though. It seems unnecessary why the same query needs to run twice when they could share the same result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org