You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/30 14:55:44 UTC
[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.
linyiqun commented on a change in pull request #1457:
URL: https://github.com/apache/hadoop-ozone/pull/1457#discussion_r497566797
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/StorageContainerNodeProtocol.java
##########
@@ -58,7 +60,8 @@
*/
RegisteredCommand register(DatanodeDetails datanodeDetails,
NodeReportProto nodeReport,
- PipelineReportsProto pipelineReport);
+ PipelineReportsProto pipelineReport,
+ LayoutVersionProto layoutVersionInfo);
Review comment:
Can you update javadoc here as we add new param layoutVersionInfo?
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -240,8 +247,19 @@ public VersionResponse getVersion(SCMVersionRequestProto versionRequest) {
@Override
public RegisteredCommand register(
DatanodeDetails datanodeDetails, NodeReportProto nodeReport,
- PipelineReportsProto pipelineReportsProto) {
-
+ PipelineReportsProto pipelineReportsProto,
+ LayoutVersionProto layoutInfo) {
+
+ if (layoutInfo != null) {
+ if (layoutInfo.getSoftwareLayoutVersion() >
+ scmLayoutVersionManager.getSoftwareLayoutVersion()) {
Review comment:
For another case, if register dn layout version lower than scm version, do we need to print some log here that can be helpful for us know some old version DN?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org