You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Randall Hauch <rh...@apache.org> on 2021/06/07 19:46:47 UTC

[VOTE] KIP-745: Connect API to restart connector and tasks

Hello all,

I would like to start a vote on KIP-745:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks

+1 (binding) from myself.

Thanks, and best regards!

Randall

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

Posted by Randall Hauch <rh...@gmail.com>.

FYI, we found a minor error in KIP-745 [1] where it described the old
behavior of the connector restart API as returning a "200 OK" response,
instead of the "204 NO CONTENT" response actually returned by this API in
AK 2.8 and earlier. See KAFKA-13139 [2] for the issue where this was
discovered and [3] for the corresponding code change. The KIP specifies
that the restart API should return the same response when the new query
parameters are `includeTasks=false` and `failedOnly=false`, which
corresponds to the REST API that was available in AK 2.8 and earlier.

I've corrected the KIP to reflect this older actual behavior of returning
"204 NO CONTENT".

We have *not* changed the KIP or the behavior of returning "202 ACCEPTED"
when the values of either or both of these query parameters is "true". Such
is the newer behavior added in KIP-745.

Best regards,

Randall


[1]
https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
[2] https://issues.apache.org/jira/browse/KAFKA-13139
[3] https://github.com/apache/kafka/pull/11132

On Thu, Jun 10, 2021 at 12:36 PM Randall Hauch <rh...@gmail.com> wrote:

> The vote passes with three binding +1s (Konstantine, Tom, me), three
> non-binding +1s (Ryanne, Kalpesh, Dongjin), and no -1 votes.
>
> Thanks all for taking the time to review and vote!
>
> Best regards,
>
> Randall
>
>
> On Thu, Jun 10, 2021 at 9:53 AM Tom Bentley <tb...@redhat.com> wrote:
>
>> Hi Randall,
>>
>> Thanks for the KIP, +1 (binding).
>>
>> Kind regards,
>>
>> Tom
>>
>> On Thu, Jun 10, 2021 at 4:09 AM Dongjin Lee <do...@apache.org> wrote:
>>
>> > +1 (non-binding).
>> >
>> > As of present:
>> >
>> > - binding: +2 (Randall, Konstantine)
>> > - non-binding: +3 (Ryanne, Kalpesh, Dongjin)
>> >
>> > We need one more +1 binding.
>> >
>> > Thanks,
>> > Dongjin
>> >
>> > On Tue, Jun 8, 2021 at 6:31 AM Kalpesh Patel
>> <kp...@confluent.io.invalid>
>> > wrote:
>> >
>> > > +1 (non-binding)
>> > >
>> > > Regards
>> > > -Kalpesh
>> > >
>> > > On Mon, Jun 7, 2021 at 3:10 PM Ryanne Dolan <ry...@gmail.com>
>> > wrote:
>> > >
>> > > > +1 (non-binding)
>> > > >
>> > > > Ryanne
>> > > >
>> > > > On Mon, Jun 7, 2021, 3:03 PM Konstantine Karantasis
>> > > > <ko...@confluent.io.invalid> wrote:
>> > > >
>> > > > > Thanks Randall.
>> > > > >
>> > > > > +1 (binding)
>> > > > >
>> > > > > Konstantine
>> > > > >
>> > > > > On Mon, Jun 7, 2021 at 12:47 PM Randall Hauch <rh...@apache.org>
>> > > wrote:
>> > > > >
>> > > > > > Hello all,
>> > > > > >
>> > > > > > I would like to start a vote on KIP-745:
>> > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
>> > > > > >
>> > > > > > +1 (binding) from myself.
>> > > > > >
>> > > > > > Thanks, and best regards!
>> > > > > >
>> > > > > > Randall
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> >
>> > --
>> > *Dongjin Lee*
>> >
>> > *A hitchhiker in the mathematical world.*
>> >
>> >
>> >
>> > *github:  <http://goog_969573159/>github.com/dongjinleekr
>> > <https://github.com/dongjinleekr>keybase:
>> https://keybase.io/dongjinleekr
>> > <https://keybase.io/dongjinleekr>linkedin:
>> kr.linkedin.com/in/dongjinleekr
>> > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck:
>> > speakerdeck.com/dongjin
>> > <https://speakerdeck.com/dongjin>*
>> >
>>
>

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

Posted by Randall Hauch <rh...@gmail.com>.

The vote passes with three binding +1s (Konstantine, Tom, me), three
non-binding +1s (Ryanne, Kalpesh, Dongjin), and no -1 votes.

Thanks all for taking the time to review and vote!

Best regards,

Randall


On Thu, Jun 10, 2021 at 9:53 AM Tom Bentley <tb...@redhat.com> wrote:

> Hi Randall,
>
> Thanks for the KIP, +1 (binding).
>
> Kind regards,
>
> Tom
>
> On Thu, Jun 10, 2021 at 4:09 AM Dongjin Lee <do...@apache.org> wrote:
>
> > +1 (non-binding).
> >
> > As of present:
> >
> > - binding: +2 (Randall, Konstantine)
> > - non-binding: +3 (Ryanne, Kalpesh, Dongjin)
> >
> > We need one more +1 binding.
> >
> > Thanks,
> > Dongjin
> >
> > On Tue, Jun 8, 2021 at 6:31 AM Kalpesh Patel <kpatel@confluent.io.invalid
> >
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > Regards
> > > -Kalpesh
> > >
> > > On Mon, Jun 7, 2021 at 3:10 PM Ryanne Dolan <ry...@gmail.com>
> > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > Ryanne
> > > >
> > > > On Mon, Jun 7, 2021, 3:03 PM Konstantine Karantasis
> > > > <ko...@confluent.io.invalid> wrote:
> > > >
> > > > > Thanks Randall.
> > > > >
> > > > > +1 (binding)
> > > > >
> > > > > Konstantine
> > > > >
> > > > > On Mon, Jun 7, 2021 at 12:47 PM Randall Hauch <rh...@apache.org>
> > > wrote:
> > > > >
> > > > > > Hello all,
> > > > > >
> > > > > > I would like to start a vote on KIP-745:
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
> > > > > >
> > > > > > +1 (binding) from myself.
> > > > > >
> > > > > > Thanks, and best regards!
> > > > > >
> > > > > > Randall
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> > --
> > *Dongjin Lee*
> >
> > *A hitchhiker in the mathematical world.*
> >
> >
> >
> > *github:  <http://goog_969573159/>github.com/dongjinleekr
> > <https://github.com/dongjinleekr>keybase:
> https://keybase.io/dongjinleekr
> > <https://keybase.io/dongjinleekr>linkedin:
> kr.linkedin.com/in/dongjinleekr
> > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck:
> > speakerdeck.com/dongjin
> > <https://speakerdeck.com/dongjin>*
> >
>

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

Posted by Tom Bentley <tb...@redhat.com>.

Hi Randall,

Thanks for the KIP, +1 (binding).

Kind regards,

Tom

On Thu, Jun 10, 2021 at 4:09 AM Dongjin Lee <do...@apache.org> wrote:

> +1 (non-binding).
>
> As of present:
>
> - binding: +2 (Randall, Konstantine)
> - non-binding: +3 (Ryanne, Kalpesh, Dongjin)
>
> We need one more +1 binding.
>
> Thanks,
> Dongjin
>
> On Tue, Jun 8, 2021 at 6:31 AM Kalpesh Patel <kp...@confluent.io.invalid>
> wrote:
>
> > +1 (non-binding)
> >
> > Regards
> > -Kalpesh
> >
> > On Mon, Jun 7, 2021 at 3:10 PM Ryanne Dolan <ry...@gmail.com>
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > Ryanne
> > >
> > > On Mon, Jun 7, 2021, 3:03 PM Konstantine Karantasis
> > > <ko...@confluent.io.invalid> wrote:
> > >
> > > > Thanks Randall.
> > > >
> > > > +1 (binding)
> > > >
> > > > Konstantine
> > > >
> > > > On Mon, Jun 7, 2021 at 12:47 PM Randall Hauch <rh...@apache.org>
> > wrote:
> > > >
> > > > > Hello all,
> > > > >
> > > > > I would like to start a vote on KIP-745:
> > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
> > > > >
> > > > > +1 (binding) from myself.
> > > > >
> > > > > Thanks, and best regards!
> > > > >
> > > > > Randall
> > > > >
> > > >
> > >
> >
>
>
> --
> *Dongjin Lee*
>
> *A hitchhiker in the mathematical world.*
>
>
>
> *github:  <http://goog_969573159/>github.com/dongjinleekr
> <https://github.com/dongjinleekr>keybase: https://keybase.io/dongjinleekr
> <https://keybase.io/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> <https://kr.linkedin.com/in/dongjinleekr>speakerdeck:
> speakerdeck.com/dongjin
> <https://speakerdeck.com/dongjin>*
>

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

Posted by Dongjin Lee <do...@apache.org>.

+1 (non-binding).

As of present:

- binding: +2 (Randall, Konstantine)
- non-binding: +3 (Ryanne, Kalpesh, Dongjin)

We need one more +1 binding.

Thanks,
Dongjin

On Tue, Jun 8, 2021 at 6:31 AM Kalpesh Patel <kp...@confluent.io.invalid>
wrote:

> +1 (non-binding)
>
> Regards
> -Kalpesh
>
> On Mon, Jun 7, 2021 at 3:10 PM Ryanne Dolan <ry...@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > Ryanne
> >
> > On Mon, Jun 7, 2021, 3:03 PM Konstantine Karantasis
> > <ko...@confluent.io.invalid> wrote:
> >
> > > Thanks Randall.
> > >
> > > +1 (binding)
> > >
> > > Konstantine
> > >
> > > On Mon, Jun 7, 2021 at 12:47 PM Randall Hauch <rh...@apache.org>
> wrote:
> > >
> > > > Hello all,
> > > >
> > > > I would like to start a vote on KIP-745:
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
> > > >
> > > > +1 (binding) from myself.
> > > >
> > > > Thanks, and best regards!
> > > >
> > > > Randall
> > > >
> > >
> >
>


-- 
*Dongjin Lee*

*A hitchhiker in the mathematical world.*



*github:  <http://goog_969573159/>github.com/dongjinleekr
<https://github.com/dongjinleekr>keybase: https://keybase.io/dongjinleekr
<https://keybase.io/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<https://kr.linkedin.com/in/dongjinleekr>speakerdeck: speakerdeck.com/dongjin
<https://speakerdeck.com/dongjin>*

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

Posted by Kalpesh Patel <kp...@confluent.io.INVALID>.

+1 (non-binding)

Regards
-Kalpesh

On Mon, Jun 7, 2021 at 3:10 PM Ryanne Dolan <ry...@gmail.com> wrote:

> +1 (non-binding)
>
> Ryanne
>
> On Mon, Jun 7, 2021, 3:03 PM Konstantine Karantasis
> <ko...@confluent.io.invalid> wrote:
>
> > Thanks Randall.
> >
> > +1 (binding)
> >
> > Konstantine
> >
> > On Mon, Jun 7, 2021 at 12:47 PM Randall Hauch <rh...@apache.org> wrote:
> >
> > > Hello all,
> > >
> > > I would like to start a vote on KIP-745:
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
> > >
> > > +1 (binding) from myself.
> > >
> > > Thanks, and best regards!
> > >
> > > Randall
> > >
> >
>

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

Posted by Ryanne Dolan <ry...@gmail.com>.

+1 (non-binding)

Ryanne

On Mon, Jun 7, 2021, 3:03 PM Konstantine Karantasis
<ko...@confluent.io.invalid> wrote:

> Thanks Randall.
>
> +1 (binding)
>
> Konstantine
>
> On Mon, Jun 7, 2021 at 12:47 PM Randall Hauch <rh...@apache.org> wrote:
>
> > Hello all,
> >
> > I would like to start a vote on KIP-745:
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
> >
> > +1 (binding) from myself.
> >
> > Thanks, and best regards!
> >
> > Randall
> >
>

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

Posted by Konstantine Karantasis <ko...@confluent.io.INVALID>.

Thanks Randall.

+1 (binding)

Konstantine

On Mon, Jun 7, 2021 at 12:47 PM Randall Hauch <rh...@apache.org> wrote:

> Hello all,
>
> I would like to start a vote on KIP-745:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks
>
> +1 (binding) from myself.
>
> Thanks, and best regards!
>
> Randall
>