[GitHub] [gobblin] jack-moseley commented on a change in pull request #3410: [GOBBLIN-1559] Support wildcard for input paths

[GitBox <gi...@apache.org>]

jack-moseley commented on a change in pull request #3410:
URL: https://github.com/apache/gobblin/pull/3410#discussion_r725219809



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/FSDatasetDescriptor.java
##########
@@ -89,6 +89,12 @@ public FSDatasetDescriptor(Config config) throws IOException {
   protected boolean isPathContaining(DatasetDescriptor other) {
     String otherPath = other.getPath();
     String otherSubPaths = ((FSDatasetDescriptor) other).getSubPaths();
+
+    // Covers special case where input path is a glob pattern

Review comment:
       Let's make this comment a bit more precise, this allows the special case where "other" is a glob, but is also an exact match with this path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org