[jira] [Commented] (CASSANDRA-7155) Followup to 6914: null handling, duplicate column in resultSet and cleanup

["Tyler Hobbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000017#comment-14000017 ] 

Tyler Hobbs commented on CASSANDRA-7155:
----------------------------------------

+1

> Followup to 6914: null handling, duplicate column in resultSet and cleanup
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-7155
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7155
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 2.0.8
>
>
> The patch for CASSANDRA-6914 left a few stuffs not properly handled:
> # A condition like {{IF m['foo'] = null}} is not handled and throw a NPE.
> # It's using ByteBuffer.equals() to compare 2 collection values which is generally incorrect (the actual comparator should be used).
> # If 2 conditions on 2 elements of the same collection were provided and the CAS failed, then the collection was duplicated in the resultSet.
> # The ColumnCondition.WithVariables was generally a bit inefficient/ugly: it can lead to bind multiple times the same terms which is unnecessary. It's cleaner to directly create a condition with bound values.



--
This message was sent by Atlassian JIRA
(v6.2#6252)