You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Anders Hammar <an...@hammar.net> on 2017/02/01 12:33:11 UTC
Fwd: [jira] [Resolved] (MNG-5971) Imported dependencies should be
available to inheritance processing
I don't understand. Why is this marked as fixed (with no commit reference)
if it's on the 3.6.0-candidate list? There have been several similar cases
just recently; has there been some incorrect jira update?
/Anders
---------- Forwarded message ----------
From: Christian Schulte (JIRA) <ji...@apache.org>
Date: Wed, Feb 1, 2017 at 12:40 AM
Subject: [jira] [Resolved] (MNG-5971) Imported dependencies should be
available to inheritance processing
To: issues@maven.apache.org
[ https://issues.apache.org/jira/browse/MNG-5971?page=com.
atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schulte resolved MNG-5971.
------------------------------------
Resolution: Fixed
> Imported dependencies should be available to inheritance processing
> -------------------------------------------------------------------
>
> Key: MNG-5971
> URL: https://issues.apache.org/jira/browse/MNG-5971
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
> Affects Versions: 3.3.3
> Reporter: Stephane Nicoll
> Assignee: Christian Schulte
> Priority: Trivial
> Fix For: 3.6.0-candidate
>
> Attachments: bom-cloud.zip
>
>
> When a project extends from a parent with a {{dependencyManagement}}
section, it is not always possible to properly override (and align) the
version to use for a group of dependencies.
> We typically use Bill Of Materials to gather a group of modules and make
sure their versions are consistent.
> The following project demonstrates the issue: https://github.com/snicoll-
scratches/maven-dependency-management
> The first commit is a working use case where the parent uses a bom with
version A and we use the same bom with version B in the child. Version B is
used as expected.
> The second commit demonstrates the faulty scenario. Rather than using a
bom in the parent, we use a direct dependency (provided by that bom). We
still use the bom with a different version. In that case all the
dependencies but the one provided by the parent are overridden (leading to
mixed versions for the dependencies provided by the BOM).
> It looks like the distance is still used to compute the version while the
graph of dependencies should be flatten at each step for a proper override.
> Thoughts? Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Re: Fwd: [jira] [Resolved] (MNG-5971) Imported dependencies should be
available to inheritance processing
Posted by Christian Schulte <cs...@schulte.it>.
Am 02/02/17 um 00:35 schrieb Christian Schulte:
> Am 02/01/17 um 13:33 schrieb Anders Hammar:
>> I don't understand. Why is this marked as fixed (with no commit reference)
>> if it's on the 3.6.0-candidate list? There have been several similar cases
>> just recently; has there been some incorrect jira update?
>>
>> /Anders
>
> The issue is not closed. Just resolved to indicate work on the issue has
> finished. Same for the other issues I marked as resolved. Jenkins will
> add the commits when they get merged to master sometime in the future.
> Master currently is at 3.5.0-SNAPSHOT. The issue is on the list for
> 3.6.0. Same for the other issues. Jenkins is not adding commits to
> issues not on master, AFAIK. 3.4.0 was ready for release. All issues
> were solved. No one needs to work on them any more. All commits have
> been squashed and pushed to branches. The branches are in order to be
> merged to master. The last branch is currently named DEPMGMT. You can
> take a look at the other branches in the shortlog of that branch here:
>
> <https://git-wip-us.apache.org/repos/asf?p=maven.git;a=shortlog;h=refs/heads/DEPMGMT>
>
> Start by looking at the MNG-2199 branch branched off of master. That has
> 3.5.0-SNAPSHOT in the poms. When that branch is merged to master, it
> will disappear in that shortlog an the next branch to merge to master
> will be DEPMGMT-IMPORT which already has 3.5.1-SNAPSHOT in the poms.
> When that is merged to master the next branch to merge to master will be
> DEPMGMT-INCLUDE which already has 3.6.0-SNAPSHOT in the poms. When that
> is merged to master the next branch to merge to master will be DEPMGMT
> which additionally to having 3.6.0-SNAPSHOT in the poms also has the
> upgrade to the resolver needed for the issues. All of this has already
> been part of all 3.4.0 preliminary testing we asked for. Work on all
> those issues is finished. Some of those commits in those branches have
> been multiple commits on the pre-reset-master branch. The one commit for
> MNG-5971 in the branch had been 36 commits in the pre-reset-master
> branch. That's what you guys all were complaining about. It's now all
> single commits per issue you can easily review when it's time to do.
> That's why I haven't close the JIRA issues and just marked them as resolved.
>
> Regards,
>
Adding to this: Most of the commit emails from me is just me rebasing
all those branches on top of each other whenever master changes to kick
off a new IT run on Jenkins with the changes to master included.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Fwd: [jira] [Resolved] (MNG-5971) Imported dependencies should be
available to inheritance processing
Posted by Christian Schulte <cs...@schulte.it>.
Am 02/01/17 um 13:33 schrieb Anders Hammar:
> I don't understand. Why is this marked as fixed (with no commit reference)
> if it's on the 3.6.0-candidate list? There have been several similar cases
> just recently; has there been some incorrect jira update?
>
> /Anders
The issue is not closed. Just resolved to indicate work on the issue has
finished. Same for the other issues I marked as resolved. Jenkins will
add the commits when they get merged to master sometime in the future.
Master currently is at 3.5.0-SNAPSHOT. The issue is on the list for
3.6.0. Same for the other issues. Jenkins is not adding commits to
issues not on master, AFAIK. 3.4.0 was ready for release. All issues
were solved. No one needs to work on them any more. All commits have
been squashed and pushed to branches. The branches are in order to be
merged to master. The last branch is currently named DEPMGMT. You can
take a look at the other branches in the shortlog of that branch here:
<https://git-wip-us.apache.org/repos/asf?p=maven.git;a=shortlog;h=refs/heads/DEPMGMT>
Start by looking at the MNG-2199 branch branched off of master. That has
3.5.0-SNAPSHOT in the poms. When that branch is merged to master, it
will disappear in that shortlog an the next branch to merge to master
will be DEPMGMT-IMPORT which already has 3.5.1-SNAPSHOT in the poms.
When that is merged to master the next branch to merge to master will be
DEPMGMT-INCLUDE which already has 3.6.0-SNAPSHOT in the poms. When that
is merged to master the next branch to merge to master will be DEPMGMT
which additionally to having 3.6.0-SNAPSHOT in the poms also has the
upgrade to the resolver needed for the issues. All of this has already
been part of all 3.4.0 preliminary testing we asked for. Work on all
those issues is finished. Some of those commits in those branches have
been multiple commits on the pre-reset-master branch. The one commit for
MNG-5971 in the branch had been 36 commits in the pre-reset-master
branch. That's what you guys all were complaining about. It's now all
single commits per issue you can easily review when it's time to do.
That's why I haven't close the JIRA issues and just marked them as resolved.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org