You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by David Chen <dc...@linkedin.com> on 2014/09/05 23:59:36 UTC
Review Request 25401: SAMZA-403: Consolidate hello-samza example job
in one project.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25401/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-403
https://issues.apache.org/jira/browse/SAMZA-403
Repository: samza-hello-samza
Description
-------
SAMZA-403: Consolidate hello-samza example job in one project.
Diffs
-----
.gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
pom.xml f38f8f8e503954e5fabb83e3470c1aba0fc37473
samza-job-package/pom.xml 9de26b52c7e0b0b2478b36947ca231726419c040
samza-job-package/src/main/assembly/src.xml 0daafcb968697dd6120aa71cf0000170196200de
samza-job-package/src/main/config/wikipedia-feed.properties
samza-job-package/src/main/config/wikipedia-parser.properties
samza-job-package/src/main/config/wikipedia-stats.properties
samza-job-package/src/main/resources/log4j.xml
samza-wikipedia/pom.xml 671bdd5d2f069ba0a5d21743de1dc5f625805d48
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
Diff: https://reviews.apache.org/r/25401/diff/
Testing
-------
Manual
Thanks,
David Chen
Re: Review Request 25401: SAMZA-403: Consolidate hello-samza example
job in one project.
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25401/#review52528
-----------------------------------------------------------
pom.xml
<https://reviews.apache.org/r/25401/#comment91324>
While we're at it, we should update this link to point to the proper url.
pom.xml
<https://reviews.apache.org/r/25401/#comment91325>
What's this for? I can't seem to find it in the old pom.xml files.
- Chris Riccomini
On Sept. 5, 2014, 9:59 p.m., David Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25401/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2014, 9:59 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-403
> https://issues.apache.org/jira/browse/SAMZA-403
>
>
> Repository: samza-hello-samza
>
>
> Description
> -------
>
> SAMZA-403: Consolidate hello-samza example job in one project.
>
>
> Diffs
> -----
>
> .gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
> pom.xml f38f8f8e503954e5fabb83e3470c1aba0fc37473
> samza-job-package/pom.xml 9de26b52c7e0b0b2478b36947ca231726419c040
> samza-job-package/src/main/assembly/src.xml 0daafcb968697dd6120aa71cf0000170196200de
> samza-job-package/src/main/config/wikipedia-feed.properties
> samza-job-package/src/main/config/wikipedia-parser.properties
> samza-job-package/src/main/config/wikipedia-stats.properties
> samza-job-package/src/main/resources/log4j.xml
> samza-wikipedia/pom.xml 671bdd5d2f069ba0a5d21743de1dc5f625805d48
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
> samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
>
> Diff: https://reviews.apache.org/r/25401/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> David Chen
>
>
Re: Review Request 25401: SAMZA-403: Consolidate hello-samza example
job in one project.
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25401/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 11:50 p.m.)
Review request for samza.
Changes
-------
Address RB comments.
Bugs: SAMZA-403
https://issues.apache.org/jira/browse/SAMZA-403
Repository: samza-hello-samza
Description
-------
SAMZA-403: Consolidate hello-samza example job in one project.
Diffs (updated)
-----
.gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
pom.xml f38f8f8e503954e5fabb83e3470c1aba0fc37473
samza-job-package/pom.xml 9de26b52c7e0b0b2478b36947ca231726419c040
samza-job-package/src/main/assembly/src.xml 0daafcb968697dd6120aa71cf0000170196200de
samza-job-package/src/main/config/wikipedia-feed.properties
samza-job-package/src/main/config/wikipedia-parser.properties
samza-job-package/src/main/config/wikipedia-stats.properties
samza-job-package/src/main/resources/log4j.xml
samza-wikipedia/pom.xml 671bdd5d2f069ba0a5d21743de1dc5f625805d48
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
Diff: https://reviews.apache.org/r/25401/diff/
Testing
-------
Manual
Thanks,
David Chen
Re: Review Request 25401: SAMZA-403: Consolidate hello-samza example
job in one project.
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25401/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 9:59 p.m.)
Review request for samza.
Bugs: SAMZA-403
https://issues.apache.org/jira/browse/SAMZA-403
Repository: samza-hello-samza
Description
-------
SAMZA-403: Consolidate hello-samza example job in one project.
Diffs
-----
.gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
pom.xml f38f8f8e503954e5fabb83e3470c1aba0fc37473
samza-job-package/pom.xml 9de26b52c7e0b0b2478b36947ca231726419c040
samza-job-package/src/main/assembly/src.xml 0daafcb968697dd6120aa71cf0000170196200de
samza-job-package/src/main/config/wikipedia-feed.properties
samza-job-package/src/main/config/wikipedia-parser.properties
samza-job-package/src/main/config/wikipedia-stats.properties
samza-job-package/src/main/resources/log4j.xml
samza-wikipedia/pom.xml 671bdd5d2f069ba0a5d21743de1dc5f625805d48
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
Diff: https://reviews.apache.org/r/25401/diff/
Testing
-------
Manual
Thanks,
David Chen
Re: Review Request 25401: SAMZA-403: Consolidate hello-samza example
job in one project.
Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25401/
-----------------------------------------------------------
(Updated Sept. 5, 2014, 9:59 p.m.)
Review request for samza.
Bugs: SAMZA-403
https://issues.apache.org/jira/browse/SAMZA-403
Repository: samza-hello-samza
Description
-------
SAMZA-403: Consolidate hello-samza example job in one project.
Diffs
-----
.gitignore 189830940b08a9b346c9a369a4a37eeda2f1539d
pom.xml f38f8f8e503954e5fabb83e3470c1aba0fc37473
samza-job-package/pom.xml 9de26b52c7e0b0b2478b36947ca231726419c040
samza-job-package/src/main/assembly/src.xml 0daafcb968697dd6120aa71cf0000170196200de
samza-job-package/src/main/config/wikipedia-feed.properties
samza-job-package/src/main/config/wikipedia-parser.properties
samza-job-package/src/main/config/wikipedia-stats.properties
samza-job-package/src/main/resources/log4j.xml
samza-wikipedia/pom.xml 671bdd5d2f069ba0a5d21743de1dc5f625805d48
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaConsumer.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaFeed.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/system/WikipediaSystemFactory.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaFeedStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaParserStreamTask.java
samza-wikipedia/src/main/java/samza/examples/wikipedia/task/WikipediaStatsStreamTask.java
Diff: https://reviews.apache.org/r/25401/diff/
Testing
-------
Manual
Thanks,
David Chen