You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/08/23 16:21:24 UTC
[GitHub] [tvm] jtuyls opened a new pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
jtuyls opened a new pull request #8815:
URL: https://github.com/apache/tvm/pull/8815
This PR updates the Vitis AI docker and documentation to the Vitis AI 1.4 release. The following PR should be merged first for tests to pass: https://github.com/apache/tvm/pull/8814.
@comaniac @leandron @zhiics Could you help with reviewing this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#issuecomment-926622771
> @leandron Has the CI been updated to include the changes in #8814? Then I will fix the conflicts here and retrigger the build.
Sorry I lost track of recent updates.
The current image versions are listed in the Jenkinsfile. It is possible to `docker pull` them to check:
https://github.com/apache/tvm/blob/d3d7e8eb6c201506dc706a055e16eed189dcdb0b/Jenkinsfile#L47-L53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a change in pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#discussion_r695254201
##########
File path: docker/Dockerfile.demo_vitis_ai
##########
@@ -16,7 +16,7 @@
# under the License.
# CI docker VAI env
-FROM xilinx/vitis-ai:latest
+FROM xilinx/vitis-ai:1.4.916
Review comment:
Ah yeah. You're right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a change in pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#discussion_r694273401
##########
File path: tests/python/contrib/test_vitis_ai/infrastructure.py
##########
@@ -85,6 +85,7 @@ def build_module(
):
if enable_vitis_ai:
mod = partition_for_vitis_ai(mod, params, dpu_target)
+ print(mod)
Review comment:
Remove print.
##########
File path: docker/Dockerfile.demo_vitis_ai
##########
@@ -16,7 +16,7 @@
# under the License.
# CI docker VAI env
-FROM xilinx/vitis-ai:latest
+FROM xilinx/vitis-ai:1.4.916
Review comment:
I think you also need to put this change (and other docker related changes) to #8814? Otherwise this PR won't be able to use the latest image anyways.
##########
File path: tests/python/contrib/test_vitis_ai/test_vitis_ai_codegen.py
##########
@@ -46,19 +50,22 @@ def set_func_attr(func, compile_name, symbol_name):
def test_conv2d():
- """Test conv2d operator for Vitis-AI DPUCADX8G and DPUCZDX8G-zcu104 targets"""
+ """Test conv2d operator for Vitis AI DPU targets"""
x = relay.var("x", shape=(1, 3, 224, 224))
w = relay.const(np.zeros((16, 3, 3, 3), dtype="float32"))
y = relay.nn.conv2d(x, w, strides=[2, 2], padding=[1, 1, 1, 1], kernel_size=[3, 3])
func = relay.Function([x], y)
params = {}
- params["x"] = np.zeros((1, 3, 224, 224), dtype="float32")
params["w"] = np.random.rand(16, 3, 3, 3).astype("float32")
mod = tvm.IRModule()
mod["main"] = func
- verify_codegen(mod, params=params, dpu_target="DPUCADX8G")
- verify_codegen(mod, params=params, dpu_target="DPUCZDX8G-zcu104")
+ verify_codegen(mod, params=params, dpu_target="DPUCADF8H", tvm_ops=2)
Review comment:
Consider using parameterized test:
```python
@pytest.mark.parametrize("target", ["DPUCADF8H", ....])
def test_conv2d():
```
And change the bottom to be
```python
if __name__ == "__main__":
if sys.platform == "win32":
print("Skip test on Windows for now")
sys.exit(0)
pytest.main([__file__])
```
##########
File path: tests/python/contrib/test_vitis_ai/test_vitis_ai_codegen.py
##########
@@ -46,19 +50,22 @@ def set_func_attr(func, compile_name, symbol_name):
def test_conv2d():
- """Test conv2d operator for Vitis-AI DPUCADX8G and DPUCZDX8G-zcu104 targets"""
+ """Test conv2d operator for Vitis AI DPU targets"""
x = relay.var("x", shape=(1, 3, 224, 224))
w = relay.const(np.zeros((16, 3, 3, 3), dtype="float32"))
y = relay.nn.conv2d(x, w, strides=[2, 2], padding=[1, 1, 1, 1], kernel_size=[3, 3])
func = relay.Function([x], y)
params = {}
- params["x"] = np.zeros((1, 3, 224, 224), dtype="float32")
params["w"] = np.random.rand(16, 3, 3, 3).astype("float32")
mod = tvm.IRModule()
mod["main"] = func
- verify_codegen(mod, params=params, dpu_target="DPUCADX8G")
- verify_codegen(mod, params=params, dpu_target="DPUCZDX8G-zcu104")
+ verify_codegen(mod, params=params, dpu_target="DPUCADF8H", tvm_ops=2)
Review comment:
You can consider using parameterized tests:
```python
@pytest.mark.parametrize("target", ["DPUCADF8H", ....])
def test_conv2d():
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #8815:
URL: https://github.com/apache/tvm/pull/8815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#issuecomment-926678457
> @leandron I checked the ci-cpu docker image and the PyXIR version being used is still v0.1.6 so the CI needs to be updated. Could you update the CI?
To update the images you need to create a ticket here: https://github.com/apache/tvm/issues/new?assignees=&labels=&template=ci-image.md&title=%5BCI+Image%5D+
I actually don't have enough privileges to update CI, that's why we need those tickets, cc @jroesch @areusch and @tqchen as they have the credentials for the systems to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jtuyls commented on pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
jtuyls commented on pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#issuecomment-926620710
@leandron Has the CI been updated to include the changes in https://github.com/apache/tvm/pull/8814? Then I will fix the conflicts here and retrigger the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jtuyls commented on pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
jtuyls commented on pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#issuecomment-934516893
@comaniac Tests are passing with the ci-cpu image update. Could you have another look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jtuyls commented on a change in pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
jtuyls commented on a change in pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#discussion_r695176152
##########
File path: docker/Dockerfile.demo_vitis_ai
##########
@@ -16,7 +16,7 @@
# under the License.
# CI docker VAI env
-FROM xilinx/vitis-ai:latest
+FROM xilinx/vitis-ai:1.4.916
Review comment:
This is the main Vitis AI docker used in the documentation and this docker isn't used for CI as we are only running tests within the `ci_cpu` docker. So, the change doesn't need to be in the other PR. I noticed the line above says `# CI docker VAI env`, which is still there from the original `ci_vitis_ai` name we used. I changed it to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jtuyls commented on pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
jtuyls commented on pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#issuecomment-926652944
@leandron I checked the ci-cpu docker image and the PyXIR version being used is still v0.1.6 so the CI needs to be updated. Could you update the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #8815: [VitisAI] Update Vitis AI integration to 1.4 release
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #8815:
URL: https://github.com/apache/tvm/pull/8815#issuecomment-934588764
Thanks @jtuyls, and also @leandron for helping update the CI :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org