You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "GitToTheHub (via GitHub)" <gi...@apache.org> on 2026/05/14 16:39:39 UTC
[PR] chore: remove redundant Hello World template files [cordova-ios]
GitToTheHub opened a new pull request, #1650:
URL: https://github.com/apache/cordova-ios/pull/1650
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
- iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
- These files will be copied from the Cordova project to the platform folder already. Also this makes maintaining the hello world template more difficult.
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub merged PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650#issuecomment-4452904993
## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1650?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 77.08%. Comparing base ([`00695c4`](https://app.codecov.io/gh/apache/cordova-ios/commit/00695c4c29429dab11d6e0b27265f00481bc27ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8cda2cd`](https://app.codecov.io/gh/apache/cordova-ios/commit/8cda2cd98def218ea3bbf96e5f4fcfc4d8dff38d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1650 +/- ##
==========================================
- Coverage 78.25% 77.08% -1.17%
==========================================
Files 17 17
Lines 5159 5159
==========================================
- Hits 4037 3977 -60
- Misses 1122 1182 +60
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1650?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on code in PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650#discussion_r3243204370
##########
templates/project/www/.gitkeep:
##########
@@ -0,0 +1 @@
+This is a placeholder file, so the www dir exists in git
Review Comment:
IIRC `prepare` happens at publish time, and I don't know if the empty folder will get included in the npm tarball. It's probably clearer and less confusing to just have the directory on the filesystem with a README
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650#issuecomment-4452919422
Hi @erisu, the action Audit Licenses fails with the error:
```bash
INFO: Apache Creadur RAT 0.17 (Apache Software Foundation)
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
{
"unknown": 1,
"unapproved": 1,
"done": true,
"files": [
"/templates/project/www/.gitkeep"
]
}
Exception in thread "main" org.apache.rat.document.RatDocumentAnalysisException: Issues with UNAPPROVED
at org.apache.rat.Report.main(Report.java:53)
Error: Process completed with exit code 1.
```
Link: https://github.com/apache/cordova-ios/actions/runs/25873722147/job/76035365246?pr=1650
Why it has Problems with the file `.gitkeep`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on code in PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650#discussion_r3243256515
##########
templates/project/www/.gitkeep:
##########
@@ -0,0 +1 @@
+This is a placeholder file, so the www dir exists in git
Review Comment:
Ok, I added the README and remove the prepare script for creating the dir
##########
templates/project/www/.gitkeep:
##########
@@ -0,0 +1 @@
+This is a placeholder file, so the www dir exists in git
Review Comment:
Ok, I added the README and removed the prepare script for creating the dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on code in PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650#discussion_r3243164184
##########
templates/project/www/.gitkeep:
##########
@@ -0,0 +1 @@
+This is a placeholder file, so the www dir exists in git
Review Comment:
Ok thanks, I didn't know that this is the issue. I added `mkdir -p templates/project/www` to the prepare script of the package.json, which would make a placeholder file unnecessary. I will see if the actions run now fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on code in PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650#discussion_r3243034497
##########
templates/project/www/.gitkeep:
##########
@@ -0,0 +1 @@
+This is a placeholder file, so the www dir exists in git
Review Comment:
You need the Apache licence header here, since this file is detected as being plaintext.
It might be better to use a README file, similar to https://github.com/apache/cordova-ios/blob/00695c4c29429dab11d6e0b27265f00481bc27ca/templates/project/App/Plugins/README
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: remove redundant Hello World template files [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #1650:
URL: https://github.com/apache/cordova-ios/pull/1650#issuecomment-4458863223
I no one has any objections, I would merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org