You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/10 09:57:40 UTC

[GitHub] [incubator-superset] codecov-io commented on pull request #11996: fix: Fix style for error modal

codecov-io commented on pull request #11996:
URL: https://github.com/apache/incubator-superset/pull/11996#issuecomment-742414011


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11996?src=pr&el=h1) Report
   > Merging [#11996](https://codecov.io/gh/apache/incubator-superset/pull/11996?src=pr&el=desc) (1e0732b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7e6f04fce4321cee9d69b14fa003e4c24b5cf720?el=desc) (7e6f04f) will **decrease** coverage by `0.17%`.
   > The diff coverage is `89.83%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11996/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11996?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11996      +/-   ##
   ==========================================
   - Coverage   63.75%   63.58%   -0.18%     
   ==========================================
     Files         941      466     -475     
     Lines       45654    28682   -16972     
     Branches     4389        0    -4389     
   ==========================================
   - Hits        29106    18237   -10869     
   + Misses      16371    10445    -5926     
   + Partials      177        0     -177     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `63.58% <89.83%> (-0.68%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11996?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...5daced1f0e76\_reports\_add\_working\_timeout\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81ZGFjZWQxZjBlNzZfcmVwb3J0c19hZGRfd29ya2luZ190aW1lb3V0X2NvbHVtbi5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `84.21% <ø> (ø)` | |
   | [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <ø> (ø)` | |
   | [superset/tasks/scheduler.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <66.66%> (-3.33%)` | :arrow_down: |
   | [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.50% <90.99%> (-3.80%)` | :arrow_down: |
   | [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `96.87% <100.00%> (+0.38%)` | :arrow_up: |
   | [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.42% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `98.71% <100.00%> (+0.03%)` | :arrow_up: |
   | ... and [479 more](https://codecov.io/gh/apache/incubator-superset/pull/11996/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11996?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11996?src=pr&el=footer). Last update [7e6f04f...dbe3c8d](https://codecov.io/gh/apache/incubator-superset/pull/11996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org