You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/02 10:12:43 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #6487: test(http-logger): fetch request and response body test case

spacewander commented on a change in pull request #6487:
URL: https://github.com/apache/apisix/pull/6487#discussion_r817541767



##########
File path: t/lib/server.lua
##########
@@ -46,6 +46,14 @@ local function inject_headers()
     end
 end
 
+local function str_split(str, reps)

Review comment:
       Let's add the mock API in the test file like:
   https://github.com/apache/apisix/blob/4feab8e6bf1cf8ffd16440848b693ce14a792fbc/t/plugin/clickhouse-logger.t#L39
   
   It's not commonly used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org