You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/05 03:07:51 UTC

[GitHub] [spark] 10110346 commented on a change in pull request #23695: [SPARK-26780][CORE]Improve shuffle read using ReadAheadInputStream

10110346 commented on a change in pull request #23695: [SPARK-26780][CORE]Improve shuffle read using ReadAheadInputStream 
URL: https://github.com/apache/spark/pull/23695#discussion_r281002085
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -945,6 +945,12 @@ package object config {
       .booleanConf
       .createWithDefault(false)
 
+  private[spark] val SHUFFLE_READ_AHEAD =
+    ConfigBuilder("spark.shuffle.read.ahead.enabled")
 
 Review comment:
   Yeah, It's better to remove this configuration. 
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org