You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/01/30 12:02:01 UTC

[GitHub] [guacamole-client] necouchman commented on issue #469: GUACAMOLE-890: Security: Allow image to run as non-root user

necouchman commented on issue #469: GUACAMOLE-890: Security: Allow image to run as non-root user
URL: https://github.com/apache/guacamole-client/pull/469#issuecomment-580221009
 
 
   Thanks @benrubson for the contribution.  I will try to review and maybe we can get this merged in.
   
   Off the bat, though, your commit messages need to all have the GUACAMOLE-890: prefix, and the messages should be useful and descriptive.  I'd suggest squashing some of them together - four commits for 12 lines of code is probably not necessary - and one of them, the typo fix, can definitely be squashed into another commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services