You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/07/29 10:20:56 UTC
[GitHub] flink pull request #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#test...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2310
[FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading
This PR fixes the `TaskManagerConfigurationTest#testDefaultFsParameterLoading` by creating a proper `flink-conf.yaml` file and passing the correct `--configDir` parameter.
Previously, the generated yaml had a random name (`<random UUID>.yaml`) even though it should be called `flink-conf.yaml`. In addition, the `--configDir` parameter was set to the file name, and not directory it resides in.
I don't know why this test did not fail earlier; maybe @mxm has an idea as he recently did some work on the `GlobalConfiguration`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4277_tm_configuration_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2310
----
commit fecd900b1030d0850ff8698ce85ee720c8cae613
Author: zentol <ch...@apache.org>
Date: 2016-07-29T10:15:54Z
[FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#test...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2310#discussion_r72780980
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerConfigurationTest.java ---
@@ -110,7 +110,7 @@ public void testActorSystemPortConfig() {
@Test
public void testDefaultFsParameterLoading() {
final File tmpDir = getTmpDir();
- final File confFile = new File(tmpDir, UUID.randomUUID().toString() + ".yaml");
+ final File confFile = new File(tmpDir, "flink-conf.yaml");
--- End diff --
"flink-conf.yaml" can be replaced by `GlobalConfiguration.FLINK_CONF_FILENAME`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#testDefault...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2310
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#testDefault...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2310
@mxm addressed your comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#testDefault...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2310
Thanks for the PR @zentol.
The test didn't fail because the exception is swallowed in a catch block:
```java
} catch (Exception e) {
e.printStackTrace();
}
```
It has to be changed in this PR to not swallow exceptions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2310: [FLINK-4277] Fix TaskManagerConfigurationTest#testDefault...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2310
good catch, thanks!
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---