You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2015/09/28 20:26:43 UTC

[GitHub] couchdb-mem3 pull request: Update to new couch_epi API

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-mem3/pull/14

    Update to new couch_epi API

    Depends on https://github.com/apache/couchdb-couch-epi/pull/12

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-mem3 simplify_couch_epi

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-mem3/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
    
----
commit ae6fe1522c5b0bfd9d7a3fd61713976b1b8a6a8b
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date:   2015-09-28T17:28:45Z

    Update to new couch_epi API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-mem3 pull request: Update to new couch_epi API

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb-mem3/pull/14#discussion_r40686779
  
    --- Diff: src/mem3_epi.erl ---
    @@ -0,0 +1,51 @@
    +% Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +% use this file except in compliance with the License. You may obtain a copy of
    +% the License at
    +%
    +% http://www.apache.org/licenses/LICENSE-2.0
    +%
    +% Unless required by applicable law or agreed to in writing, software
    +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +% License for the specific language governing permissions and limitations under
    +% the License.
    +
    +
    +-module(mem3_epi).
    +
    +-behaviour(couch_epi_plugin).
    +
    +-export([
    +    app/0,
    +    providers/0,
    +    services/0,
    +    data_subscriptions/0,
    +    data_providers/0,
    +    processes/0,
    +    notify/3
    +]).
    +
    +app() ->
    +    mem3.
    +
    +providers() ->
    +    [
    +         {chttpd_handlers, mem3_httpd_handlers}
    +    ].
    +
    +
    +services() ->
    +    [
    +    ].
    --- End diff --
    
    `[]` to match the following functions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-mem3 pull request: Update to new couch_epi API

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-mem3/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-mem3 pull request: Update to new couch_epi API

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:

    https://github.com/apache/couchdb-mem3/pull/14#issuecomment-144094775
  
    +1 after https://github.com/apache/couchdb-couch-epi/pull/12 is merged and comment addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---