You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Jeges (Code Review)" <ge...@cloudera.org> on 2017/09/01 15:56:45 UTC

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

Attila Jeges has posted comments on this change.

Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE
......................................................................


Patch Set 4:

> (1 comment)

The tests in this change use only 3 query options. Adding a new section to the .test files to support only these 3 options wouldn't be too much work.

On the other hand, adding support for all the query options that Impala supports would be a lot harder. Probably we would have to implement that using some Java reflection trickery.

-- 
To view, visit http://gerrit.cloudera.org:8080/7564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0f0b200e02442edcad8df3979f652d66c6e52eb
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No