You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/02/27 04:11:43 UTC
[kudu-CR] cmake: don't incorporate filenames in regexp patterns
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6161
to review the following change.
Change subject: cmake: don't incorporate filenames in regexp patterns
......................................................................
cmake: don't incorporate filenames in regexp patterns
It leads to incorrect match failures when the filenames contain regexp
metacharacters, the worst offender being '+'. I couldn't find a cmake
equivalent to java.util.regex.Pattern's \Q and \E control characters, so I
rewrote the matching logic with FIND and REPLACE instead.
With this change, building from within a directory like
kudu-1.2.0+cdh6.x+0/build/fastdebug correctly creates the 'latest' link.
Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b
---
M CMakeLists.txt
1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/6161/1
--
To view, visit http://gerrit.cloudera.org:8080/6161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] cmake: don't incorporate filenames in regexp patterns
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: cmake: don't incorporate filenames in regexp patterns
......................................................................
Patch Set 1: Verified+1
Unrelated failure in master-stress-test.
--
To view, visit http://gerrit.cloudera.org:8080/6161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cmake: don't incorporate filenames in regexp patterns
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: cmake: don't incorporate filenames in regexp patterns
......................................................................
cmake: don't incorporate filenames in regexp patterns
It leads to incorrect match failures when the filenames contain regexp
metacharacters, the worst offender being '+'. I couldn't find a cmake
equivalent to java.util.regex.Pattern's \Q and \E control characters, so I
rewrote the matching logic with FIND and REPLACE instead.
With this change, building from within a directory like
kudu-1.2.0+cdh6.x+0/build/fastdebug correctly creates the 'latest' link.
Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b
Reviewed-on: http://gerrit.cloudera.org:8080/6161
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M CMakeLists.txt
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] cmake: don't incorporate filenames in regexp patterns
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: cmake: don't incorporate filenames in regexp patterns
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No