You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/13 07:21:45 UTC
Review Request 24632: Updated health check to use the new CommandInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Summary (updated)
-----------------
Updated health check to use the new CommandInfo.
Repository: mesos-git
Description (updated)
-------
See summary.
Diffs (updated)
-----
src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789
Diff: https://reviews.apache.org/r/24632/diff/
Testing (updated)
-------
make check
Thanks,
Jie Yu
Re: Review Request 24632: Updated health check to use the new CommandInfo.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50410
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:21 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789
>
> Diff: https://reviews.apache.org/r/24632/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24632: Updated health check to use the new CommandInfo.
Posted by Timothy Chen <tn...@apache.org>.
> On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote:
> > src/health-check/main.cpp, line 171
> > <https://reviews.apache.org/r/24632/diff/1/?file=659122#file659122line171>
> >
> > Thanks for the update! Do you mind adding a test for the shell path?
>
> Jie Yu wrote:
> I think the shell path should have already been tested by the existing tests, right?
Yes sorry the new exec path that you have.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
-----------------------------------------------------------
On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:21 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789
>
> Diff: https://reviews.apache.org/r/24632/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24632: Updated health check to use the new CommandInfo.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote:
> > src/health-check/main.cpp, line 171
> > <https://reviews.apache.org/r/24632/diff/1/?file=659122#file659122line171>
> >
> > Thanks for the update! Do you mind adding a test for the shell path?
I think the shell path should have already been tested by the existing tests, right?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
-----------------------------------------------------------
On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:21 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789
>
> Diff: https://reviews.apache.org/r/24632/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24632: Updated health check to use the new CommandInfo.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote:
> > src/health-check/main.cpp, line 171
> > <https://reviews.apache.org/r/24632/diff/1/?file=659122#file659122line171>
> >
> > Thanks for the update! Do you mind adding a test for the shell path?
>
> Jie Yu wrote:
> I think the shell path should have already been tested by the existing tests, right?
>
> Timothy Chen wrote:
> Yes sorry the new exec path that you have.
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
-----------------------------------------------------------
On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:21 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789
>
> Diff: https://reviews.apache.org/r/24632/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24632: Updated health check to use the new CommandInfo.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
-----------------------------------------------------------
src/health-check/main.cpp
<https://reviews.apache.org/r/24632/#comment88180>
Thanks for the update! Do you mind adding a test for the shell path?
- Timothy Chen
On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 5:21 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789
>
> Diff: https://reviews.apache.org/r/24632/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>