You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-dev@apache.org by Jukka Zitting <ju...@gmail.com> on 2011/02/10 23:07:56 UTC

asfgit-admin.git (Was: Blog post on Gerrit (GIT review tool))

Hi Paul,

On Thu, Feb 10, 2011 at 5:01 PM, Paul Davis <pa...@gmail.com> wrote:
> I've been working on various scripts and configurations to get a more
> traditional setup over the last couple months. There current bits are
> at [1]. So far I have most of the major requirements [2] handled and
> working. The last bit of code that I need to write is the logging of
> commits so that we have a history of who pushed what.

Brilliant, I wasn't aware that you had progressed so far already!

Could you write a quick summary about what the system already does and
what still needs to be done? I'd love to try it out and see where I
could perhaps help.

Did you see my earlier Jira comment [1]? As mentioned there I think it
would be better if we kept this code under the infra svn, as at least
I would have been much better aware of your progress had I seen the
commit notifications.

Also, ask asked on Jira, do you think the system would be ready for
experimental use with my Oak lab?

[1] https://issues.apache.org/jira/browse/INFRA-3165?focusedCommentId=12972299&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12972299

BR,

Jukka Zitting

Re: asfgit-admin.git (Was: Blog post on Gerrit (GIT review tool))

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Paul Davis wrote on Fri, Feb 11, 2011 at 10:21:46 -0500:
> Didn't know it existed. I'll hook that up in a jiffy.

The list address is infrastructure-cvs@.

Re: asfgit-admin.git (Was: Blog post on Gerrit (GIT review tool))

Posted by Paul Davis <pa...@gmail.com>.
On Fri, Feb 11, 2011 at 5:06 AM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Paul Davis wrote on Thu, Feb 10, 2011 at 17:37:00 -0500:
>> On Thu, Feb 10, 2011 at 5:07 PM, Jukka Zitting <ju...@gmail.com> wrote:
>> > Hi Paul,
>> >
>> > Did you see my earlier Jira comment [1]? As mentioned there I think it
>> > would be better if we kept this code under the infra svn, as at least
>> > I would have been much better aware of your progress had I seen the
>> > commit notifications.
>>
>> So far, it's got most of the requested features listed in the INFRA
>> Git component such as:
>>
>>    * Email notifications for commits.
>
> So, why not send commit mails to infra-cvs@?
>

Didn't know it existed. I'll hook that up in a jiffy.

Re: asfgit-admin.git (Was: Blog post on Gerrit (GIT review tool))

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Paul Davis wrote on Thu, Feb 10, 2011 at 17:37:00 -0500:
> On Thu, Feb 10, 2011 at 5:07 PM, Jukka Zitting <ju...@gmail.com> wrote:
> > Hi Paul,
> >
> > Did you see my earlier Jira comment [1]? As mentioned there I think it
> > would be better if we kept this code under the infra svn, as at least
> > I would have been much better aware of your progress had I seen the
> > commit notifications.
>
> So far, it's got most of the requested features listed in the INFRA
> Git component such as:
> 
>    * Email notifications for commits.

So, why not send commit mails to infra-cvs@?

Re: asfgit-admin.git (Was: Blog post on Gerrit (GIT review tool))

Posted by Jukka Zitting <ju...@gmail.com>.
Hi,

On Thu, Feb 10, 2011 at 11:37 PM, Paul Davis
<pa...@gmail.com> wrote:
> So far, it's got most of the requested features listed in the INFRA
> Git component such as:

Sounds great!

> Yeah, I only didn't put it into SVN because I wasn't given a place to
> write to and I was trying to minimize the number of requests I was
> asking of the infra team. Also, I was worried that all life would stop
> instantaneously and then having every molecule in my body would
> explode at the speed of light [2].

That's a very good reason. :-) As Daniel mentioned, the only thing I'd
really ask for is commit notifications.

> I would say that depends on how patient you are. If you don't mind
> hitting bugs and reporting or fixing them then I'd say it's pretty
> close to ready for experimental testing.

That's exactly the state I'm looking for. The Oak lab is a hobby
project for which I have no set schedule or deadlines, so it's no
problem if the system breaks down and needs fixing. And with Git I
don't even need to worry about the server crashing entirely and taking
all my bits with it. :-)

BR,

Jukka Zitting

Re: asfgit-admin.git (Was: Blog post on Gerrit (GIT review tool))

Posted by Paul Davis <pa...@gmail.com>.
On Thu, Feb 10, 2011 at 5:07 PM, Jukka Zitting <ju...@gmail.com> wrote:
> Hi Paul,
>
> On Thu, Feb 10, 2011 at 5:01 PM, Paul Davis <pa...@gmail.com> wrote:
>> I've been working on various scripts and configurations to get a more
>> traditional setup over the last couple months. There current bits are
>> at [1]. So far I have most of the major requirements [2] handled and
>> working. The last bit of code that I need to write is the logging of
>> commits so that we have a history of who pushed what.
>
> Brilliant, I wasn't aware that you had progressed so far already!
>
> Could you write a quick summary about what the system already does and
> what still needs to be done? I'd love to try it out and see where I
> could perhaps help.
>

So far, it's got most of the requested features listed in the INFRA
Git component such as:

   * Global disable of writes
   * Authentication via ldap (mod_ldap)
   * Authorization based on ldap groups (ie to svn-authorization)
   * Disabling of rewinding trunk/master (and other branches[1])
   * Validation that every commit was committed by someone authorized
to commit to the project.
   * Email notifications for commits.

Remaining requested features are related to the logging of who pushed
what and then lots and lots of documentation for end-users and
infrastructure hosting. I'll also need to figure out how to hook up
integration with JIRA to close tickets with commit messages as well as
figure out buildbot/hudson integration for people using those.

> Did you see my earlier Jira comment [1]? As mentioned there I think it
> would be better if we kept this code under the infra svn, as at least
> I would have been much better aware of your progress had I seen the
> commit notifications.

Yeah, I only didn't put it into SVN because I wasn't given a place to
write to and I was trying to minimize the number of requests I was
asking of the infra team. Also, I was worried that all life would stop
instantaneously and then having every molecule in my body would
explode at the speed of light [2].

> Also, ask asked on Jira, do you think the system would be ready for
> experimental use with my Oak lab?
>

I would say that depends on how patient you are. If you don't mind
hitting bugs and reporting or fixing them then I'd say it's pretty
close to ready for experimental testing. I've been looking for a
couple less serious things to use as a test so that might work out
nicely.


Paul Davis


[1] I code this part so that each project can configure branch
prefixes that are non-rewindable. This way a project could register
refs/heads/master and refs/heads/rel/ as non-rewindable, and then if
all release branches are of the form rel/1.0.x they too would be
un-rewindable (this is what allows all other branches to be created
and tampered with willy nilly to allow people to have as complex of a
branching/merging strategy as they see fit).

[2] http://www.youtube.com/watch?v=jyaLZHiJJnE