You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/09/09 13:41:19 UTC
[GitHub] [kylin] nichunen commented on a change in pull request #818:
KYLIN-4153 Delete marker if real file not exists
nichunen commented on a change in pull request #818: KYLIN-4153 Delete marker if real file not exists
URL: https://github.com/apache/kylin/pull/818#discussion_r320229235
##########
File path: core-common/src/main/java/org/apache/kylin/common/persistence/PushdownResourceStore.java
##########
@@ -167,23 +170,27 @@ protected InputStream openPushdown(String resPath) throws IOException {
try {
Path p = pushdownPath(resPath);
FileSystem fs = pushdownFS();
- if (fs.exists(p))
+ if (fs.exists(p)) {
return fs.open(p);
- else
+ } else {
throw new FileNotFoundException(p.toString() + " (FS: " + fs + ")");
-
+ }
+ } catch (FileNotFoundException fileNotFound) {
Review comment:
Seems no need to catch "FileNotFoundException"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services