You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zddr (via GitHub)" <gi...@apache.org> on 2023/12/20 05:04:49 UTC
[PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
zddr opened a new pull request, #28700:
URL: https://github.com/apache/doris/pull/28700
## Proposed changes
Issue Number: close #xxx
should use InsertTimeout but QueryTimeout
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #28700:
URL: https://github.com/apache/doris/pull/28700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863886931
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.14 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17184071519 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1864010779
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863934034
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863915940
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.46 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17183822765 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863877492
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 2c1f00d86cc8d58282f41a70e74e8b396a0dfe0e, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4721 4463 4408 4408
q2 367 150 154 150
q3 1476 1199 1238 1199
q4 1113 916 870 870
q5 3142 3151 3179 3151
q6 248 129 131 129
q7 983 486 487 486
q8 2201 2219 2160 2160
q9 6695 6683 6639 6639
q10 3240 3288 3283 3283
q11 312 198 184 184
q12 358 222 212 212
q13 4532 3804 3836 3804
q14 242 215 218 215
q15 568 524 523 523
q16 453 407 393 393
q17 990 577 546 546
q18 7190 6886 6933 6886
q19 1521 1379 1399 1379
q20 502 322 334 322
q21 3072 2665 2625 2625
q22 362 297 300 297
Total cold run time: 44288 ms
Total hot run time: 39861 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4370 4378 4368 4368
q2 273 167 170 167
q3 3542 3540 3536 3536
q4 2395 2388 2374 2374
q5 5738 5771 5725 5725
q6 239 121 121 121
q7 2405 1894 1888 1888
q8 3517 3516 3513 3513
q9 9007 9004 9031 9004
q10 3921 4009 4010 4009
q11 493 370 383 370
q12 773 605 601 601
q13 4313 3569 3553 3553
q14 293 251 254 251
q15 565 532 530 530
q16 528 468 472 468
q17 1898 1884 1853 1853
q18 8615 8336 8283 8283
q19 1707 1725 1748 1725
q20 2257 1961 1948 1948
q21 6531 6189 6207 6189
q22 531 455 451 451
Total cold run time: 63911 ms
Total hot run time: 60927 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863871665
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863891420
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863932320
run pipelinex_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1864079226
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on code in PR #28700:
URL: https://github.com/apache/doris/pull/28700#discussion_r1432271798
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -402,6 +403,7 @@ public boolean isSyncLoadKindStmt() {
if (parsedStmt instanceof LogicalPlanAdapter) {
LogicalPlan logicalPlan = ((LogicalPlanAdapter) parsedStmt).getLogicalPlan();
return logicalPlan instanceof InsertIntoTableCommand
+ || logicalPlan instanceof InsertOverwriteTableCommand
Review Comment:
should also fix InsertOverwriteTableStmt for legacy planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863871607
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863859345
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](mtmv)fix insert overwrite getExecTimeout error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28700:
URL: https://github.com/apache/doris/pull/28700#issuecomment-1863905511
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 11c1ae830787f4c716ef07e3391a92c92ee1e980, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4664 4406 4478 4406
q2 371 149 162 149
q3 1477 1279 1238 1238
q4 1126 968 928 928
q5 3126 3170 3156 3156
q6 251 129 128 128
q7 994 484 482 482
q8 2199 2243 2174 2174
q9 6666 6695 6664 6664
q10 3241 3278 3291 3278
q11 301 186 191 186
q12 350 208 209 208
q13 4553 3827 3783 3783
q14 241 222 211 211
q15 569 525 525 525
q16 444 390 390 390
q17 997 572 549 549
q18 7237 7013 7072 7013
q19 1511 1408 1387 1387
q20 544 315 301 301
q21 3082 2599 2716 2599
q22 348 280 284 280
Total cold run time: 44292 ms
Total hot run time: 40035 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4354 4402 4343 4343
q2 269 162 170 162
q3 3539 3539 3529 3529
q4 2384 2371 2374 2371
q5 5772 5742 5742 5742
q6 241 121 123 121
q7 2391 1915 1884 1884
q8 3517 3534 3516 3516
q9 9048 9020 9015 9015
q10 3941 4015 4010 4010
q11 489 376 369 369
q12 762 594 583 583
q13 4308 3577 3561 3561
q14 282 260 250 250
q15 566 522 526 522
q16 511 455 460 455
q17 1873 1858 1876 1858
q18 8774 8213 8384 8213
q19 1760 1769 1729 1729
q20 2252 1946 1946 1946
q21 6553 6206 6196 6196
q22 491 445 411 411
Total cold run time: 64077 ms
Total hot run time: 60786 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org