You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/21 02:45:07 UTC
[GitHub] [doris] chenlinzhong opened a new pull request, #15224: [Feature] Support return bitmap data in select statement in vectoriza…
chenlinzhong opened a new pull request, #15224:
URL: https://github.com/apache/doris/pull/15224
# Proposed changes
Support return bitmap data in select statement in vectorization mode
In the scenario of using Bitmap to circle people, users need to return the Bitmap results to the upper layer, which is parsing the contents of the Bitmap to deal with high QPS query scenarios
在使用bitmap圈人场景中，用户需要把bitmap结果返回到上层，上层在去解析bitmap的内容，以应对高qps的查询场景
MySQL [test_db]> set return_object_data_as_binary=true;
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1055239605
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +93,27 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ const vectorized::ColumnComplexType<BitmapValue>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<BitmapValue>*>(
+ column.get());
+ BitmapValue bitmapValue = pColumnComplexType->get_element(i);
+ size_t size = bitmapValue.getSizeInBytes();
+ std::unique_ptr<char[]> buf(new char[size]);
+ bitmapValue.write(buf.get());
+ buf_ret = _buffer.push_string(buf.get(), size);
+ } else if (column->is_hll() && output_object_data()) {
+ const vectorized::ColumnComplexType<HyperLogLog>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<HyperLogLog>*>(
+ column.get());
+ HyperLogLog hyperLogLog = pColumnComplexType->get_element(i);
+ size_t size = hyperLogLog.max_serialized_size();
+ std::unique_ptr<char[]> buf(new char[size]);
Review Comment:
```suggestion
std::unique_ptr<char[]> buf(new char[size]);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1360803537
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1360922588
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by "chenlinzhong (via GitHub)" <gi...@apache.org>.
chenlinzhong commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1518978221
> Has this feature been released yet?
released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1360804477
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1362429757
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1361025031
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1055239605
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +93,27 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ const vectorized::ColumnComplexType<BitmapValue>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<BitmapValue>*>(
+ column.get());
+ BitmapValue bitmapValue = pColumnComplexType->get_element(i);
+ size_t size = bitmapValue.getSizeInBytes();
+ std::unique_ptr<char[]> buf(new char[size]);
+ bitmapValue.write(buf.get());
+ buf_ret = _buffer.push_string(buf.get(), size);
+ } else if (column->is_hll() && output_object_data()) {
+ const vectorized::ColumnComplexType<HyperLogLog>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<HyperLogLog>*>(
+ column.get());
+ HyperLogLog hyperLogLog = pColumnComplexType->get_element(i);
+ size_t size = hyperLogLog.max_serialized_size();
+ std::unique_ptr<char[]> buf(new char[size]);
Review Comment:
```suggestion
std::unique_ptr<char[]> buf = std::make_unique<char[]>(size);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wzqiang1332 commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by "wzqiang1332 (via GitHub)" <gi...@apache.org>.
wzqiang1332 commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1524529254
> > Has this feature been released yet?
>
> released
Do I need to add any configuration to use this feature? I can't get the bitmap data in version 1.2.3. return null;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1365083564
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1361031158
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1055238967
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +93,27 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ const vectorized::ColumnComplexType<BitmapValue>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<BitmapValue>*>(
+ column.get());
+ BitmapValue bitmapValue = pColumnComplexType->get_element(i);
+ size_t size = bitmapValue.getSizeInBytes();
+ std::unique_ptr<char[]> buf(new char[size]);
+ bitmapValue.write(buf.get());
+ buf_ret = _buffer.push_string(buf.get(), size);
+ } else if (column->is_hll() && output_object_data()) {
+ const vectorized::ColumnComplexType<HyperLogLog>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<HyperLogLog>*>(
+ column.get());
+ HyperLogLog hyperLogLog = pColumnComplexType->get_element(i);
+ size_t size = hyperLogLog.max_serialized_size();
+ std::unique_ptr<char[]> buf(new char[size]);
Review Comment:
std::unique_ptr<char[]> buf = std::make_unique<char[]>(size);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg merged pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #15224:
URL: https://github.com/apache/doris/pull/15224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] chenlinzhong commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
chenlinzhong commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1055265793
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +93,27 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ const vectorized::ColumnComplexType<BitmapValue>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<BitmapValue>*>(
+ column.get());
+ BitmapValue bitmapValue = pColumnComplexType->get_element(i);
+ size_t size = bitmapValue.getSizeInBytes();
+ std::unique_ptr<char[]> buf(new char[size]);
Review Comment:
fix
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +93,27 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ const vectorized::ColumnComplexType<BitmapValue>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<BitmapValue>*>(
+ column.get());
+ BitmapValue bitmapValue = pColumnComplexType->get_element(i);
+ size_t size = bitmapValue.getSizeInBytes();
+ std::unique_ptr<char[]> buf(new char[size]);
+ bitmapValue.write(buf.get());
+ buf_ret = _buffer.push_string(buf.get(), size);
+ } else if (column->is_hll() && output_object_data()) {
+ const vectorized::ColumnComplexType<HyperLogLog>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<HyperLogLog>*>(
+ column.get());
+ HyperLogLog hyperLogLog = pColumnComplexType->get_element(i);
+ size_t size = hyperLogLog.max_serialized_size();
+ std::unique_ptr<char[]> buf(new char[size]);
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] chenlinzhong commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
chenlinzhong commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1053962689
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +92,17 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ vectorized::ColumnComplexType<BitmapValue>* tmp =
+ (vectorized::ColumnComplexType<BitmapValue>*)column.get();
Review Comment:
fix
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +92,17 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ vectorized::ColumnComplexType<BitmapValue>* tmp =
+ (vectorized::ColumnComplexType<BitmapValue>*)column.get();
+ BitmapValue bitmapValue = tmp->get_element(i);
+ int size = bitmapValue.getSizeInBytes();
+ char buf[size];
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1055238772
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +93,27 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ const vectorized::ColumnComplexType<BitmapValue>* pColumnComplexType =
+ assert_cast<const vectorized::ColumnComplexType<BitmapValue>*>(
+ column.get());
+ BitmapValue bitmapValue = pColumnComplexType->get_element(i);
+ size_t size = bitmapValue.getSizeInBytes();
+ std::unique_ptr<char[]> buf(new char[size]);
Review Comment:
```suggestion
std::unique_ptr<char[]> buf = std::make_unique<char[]>(size);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1360829208
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by "chenlinzhong (via GitHub)" <gi...@apache.org>.
chenlinzhong commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1518978165
> released
released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wzqiang1332 commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by "wzqiang1332 (via GitHub)" <gi...@apache.org>.
wzqiang1332 commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1518969316
Has this feature been released yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1365083582
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1053932701
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +92,17 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ vectorized::ColumnComplexType<BitmapValue>* tmp =
+ (vectorized::ColumnComplexType<BitmapValue>*)column.get();
Review Comment:
vectorized::ColumnComplexType<BitmapValue>* tmp = assert_cast<const vectorized::ColumnComplexType<BitmapValue>*>(column.get());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1362276168
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
chenlinzhong commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1362503669
sub pr samples #15273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1362618555
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature] Support return bitmap data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1360773507
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1053933168
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +92,17 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& column_ptr,
}
if constexpr (type == TYPE_OBJECT) {
- buf_ret = _buffer.push_null();
+ if (column->is_bitmap() && output_object_data()) {
+ vectorized::ColumnComplexType<BitmapValue>* tmp =
+ (vectorized::ColumnComplexType<BitmapValue>*)column.get();
+ BitmapValue bitmapValue = tmp->get_element(i);
+ int size = bitmapValue.getSizeInBytes();
+ char buf[size];
Review Comment:
use std::unique_ptr< char[]> buf(new char[size]);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15224: [Feature](bitmap)Support return bitmap data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1360824759
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.6 seconds
load time: 635 seconds
storage size: 17123691743 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221221035840_clickbench_pr_65988.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15224:
URL: https://github.com/apache/doris/pull/15224#issuecomment-1362291819
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org