[jira] [Commented] (FLINK-8106) Optimize the timer logic in AbstractKeyedCEPPatternOperator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258936#comment-16258936 ] 

ASF GitHub Bot commented on FLINK-8106:
---------------------------------------

GitHub user dianfu opened a pull request:

    https://github.com/apache/flink/pull/5036

    [FLINK-8106] [cep] Optimize the timer logic in AbstractKeyedCEPPatternOperator

    ## What is the purpose of the change
    
    *This pull request optimize the performance of AbstractKeyedCEPPatternOperator*
    
    ## Verifying this change
      - *Existing tests*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dianfu/flink optimize_timer_cep

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5036.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5036
    
----
commit 74d432f998afe38ed85ff24481521e5db09805c0
Author: Dian Fu <fu...@alibaba-inc.com>
Date:   2017-11-20T08:20:53Z

    [FLINK-8106] [cep] Optimize the timer logic in AbstractKeyedCEPPatternOperator

----


> Optimize the timer logic in AbstractKeyedCEPPatternOperator
> -----------------------------------------------------------
>
>                 Key: FLINK-8106
>                 URL: https://issues.apache.org/jira/browse/FLINK-8106
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>
> Currently the logic of {{AbstractKeyedCEPPatternOperator}} is as follows when event time enabled:
> 1) When element comes, buffer it in {{MapState}} and and register a timer at {{watermark + 1}}
> 2) When event timer triggered, scan the {{MapState}} and find the elements below current watermark and process it. If there are remaining elements to process or the NFA is not empty, register a new timer at {{watermark + 1}}.
> Let's assume that watermark comes about 5 seconds later than the event on average, then we will scan about 5000 times the {{MapState}} before processing the events. We find that most of the cpu is wasted serialization and deserialization the {{MapState}} when profiling an CEP use case. After make the optimization of the timer logic, the through put increases from 10+ tps to about 3500 tps for one operator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)