You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:53:16 UTC
[GitHub] [incubator-iotdb] qiaojialin opened a new pull request #1264: [IOTDB-708] add config for inferring data type from string value
qiaojialin opened a new pull request #1264:
URL: https://github.com/apache/incubator-iotdb/pull/1264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1264: [IOTDB-708] add config for inferring data type from string value
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1264:
URL: https://github.com/apache/incubator-iotdb/pull/1264#issuecomment-633790683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1264: [IOTDB-708] add config for inferring data type from string value
Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #1264:
URL: https://github.com/apache/incubator-iotdb/pull/1264#discussion_r430139179
##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -390,6 +390,18 @@ enable_auto_create_schema=true
# we will set root.sg0 as the storage group if storage group level is 1
default_storage_group_level=1
+# ALL data types: BOOLEAN, INT32, INT64, FLOAT, DOUBLE, TEXT
+
+# when receive boolean string "true" or "false", we register the time series as BOOLEAN type
+boolean_string_infer_type=BOOLEAN
+
+# when receive an integer string "67", we register the time series as INT32 type
+integer_string_infer_type=FLOAT
Review comment:
IMO，it's better to set FLOAT as default like InfluxDB, and I encountered a scenario where the first number the user started to transmit is generally 0, which is actually of type float. In this case, if the default configuration is INT32, the insertion will not succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1264: [IOTDB-708] add config for inferring data type from string value
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #1264:
URL: https://github.com/apache/incubator-iotdb/pull/1264#discussion_r430136478
##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -390,6 +390,18 @@ enable_auto_create_schema=true
# we will set root.sg0 as the storage group if storage group level is 1
default_storage_group_level=1
+# ALL data types: BOOLEAN, INT32, INT64, FLOAT, DOUBLE, TEXT
+
+# when receive boolean string "true" or "false", we register the time series as BOOLEAN type
+boolean_string_infer_type=BOOLEAN
+
+# when receive an integer string "67", we register the time series as INT32 type
+integer_string_infer_type=FLOAT
Review comment:
INT32 by default, not float
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1264: [IOTDB-708] add config for inferring data type from string value
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #1264:
URL: https://github.com/apache/incubator-iotdb/pull/1264#issuecomment-633790683
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1264&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1264) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1264&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=1264&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1264: [IOTDB-708] add config for inferring data type from string value
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1264:
URL: https://github.com/apache/incubator-iotdb/pull/1264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org