You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/11 16:55:10 UTC
[GitHub] [spark] sarutak opened a new pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
sarutak opened a new pull request #33965:
URL: https://github.com/apache/spark/pull/33965
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to support `timestamp_ntz` as a type of time column for `SessionWIndow` like `TimeWindow` does.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For better usability.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917445235
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47671/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917755985
cc. @gengliangwang @viirya @xuanyuanking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917879494
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47694/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917886671
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47694/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917439125
**[Test build #143167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143167/testReport)** for PR 33965 at commit [`7466297`](https://github.com/apache/spark/commit/746629798c63088798620e1f4085f2349237c900).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917446465
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47671/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917446465
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47671/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917860287
**[Test build #143192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143192/testReport)** for PR 33965 at commit [`2c07421`](https://github.com/apache/spark/commit/2c07421f7a337d5d9e2f96dd0430d107b38cb1e1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917886671
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47694/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917485074
**[Test build #143167 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143167/testReport)** for PR 33965 at commit [`7466297`](https://github.com/apache/spark/commit/746629798c63088798620e1f4085f2349237c900).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-918065894
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143192/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #33965:
URL: https://github.com/apache/spark/pull/33965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-918208330
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917439125
**[Test build #143167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143167/testReport)** for PR 33965 at commit [`7466297`](https://github.com/apache/spark/commit/746629798c63088798620e1f4085f2349237c900).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917860287
**[Test build #143192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143192/testReport)** for PR 33965 at commit [`2c07421`](https://github.com/apache/spark/commit/2c07421f7a337d5d9e2f96dd0430d107b38cb1e1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917883504
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47694/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917446458
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47671/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917485313
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143167/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-917485313
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143167/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #33965:
URL: https://github.com/apache/spark/pull/33965#discussion_r707011512
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SessionWindow.scala
##########
@@ -69,10 +69,10 @@ case class SessionWindow(timeColumn: Expression, gapDuration: Expression) extend
with NonSQLExpression {
override def children: Seq[Expression] = Seq(timeColumn, gapDuration)
- override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType, AnyDataType)
+ override def inputTypes: Seq[AbstractDataType] = Seq(AnyTimestampType, AnyDataType)
override def dataType: DataType = new StructType()
- .add(StructField("start", TimestampType))
- .add(StructField("end", TimestampType))
+ .add(StructField("start", children.head.dataType))
Review comment:
nit: `children.head.dataType` => `timeColumn.dataType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-918065894
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143192/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33965: [SPARK-36724][SQL] Support timestamp_ntz as a type of time column for SessionWindow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33965:
URL: https://github.com/apache/spark/pull/33965#issuecomment-918062865
**[Test build #143192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143192/testReport)** for PR 33965 at commit [`2c07421`](https://github.com/apache/spark/commit/2c07421f7a337d5d9e2f96dd0430d107b38cb1e1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org