[GitHub] [dolphinscheduler] EricGao888 commented on pull request #13183: [Feature] Task monitoring supports task names as tags.

[GitBox <gi...@apache.org>]

EricGao888 commented on PR #13183:
URL: https://github.com/apache/dolphinscheduler/pull/13183#issuecomment-1351064935

   Hi @acongfly ,
   
   Several months ago we've discussed about using task instance id / task instance name as a dimension of tags. There might be potential memory risk when task instances accumulated, see: https://github.com/apache/dolphinscheduler/issues/10525#issuecomment-1169954936
   
   Compared to `task instance id`, `task instance name` is a better choice as there are much less distinct task names than task instance ids. BTW, you need to make sure task instance names are distinct, otherwise you might get incorrect data.
   
   However, if you want to contribute this feature, I suggest u add filters / switch for generating these kind of `high cardinality` dimensions. For users scheduling tons of different tasks, this feature might cause side-effect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org