[GitHub] [arrow] xhochy commented on a change in pull request #8325: ARROW-10206: [C++][Python][FlightRPC] Allow disabling server validation

[GitBox <gi...@apache.org>]

xhochy commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r500933507



##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -34,6 +34,9 @@
 #include <grpc++/grpc++.h>
 #endif
 
+#include "grpc/grpc_security_constants.h"
+#include "grpcpp/security/tls_credentials_options.h"

Review comment:
       External includes, thus no `"`
   ```suggestion
   #include <grpc/grpc_security_constants.h>
   #include <grpcpp/security/tls_credentials_options.h>
   ```

##########
File path: python/manylinux1/scripts/build_re2.sh
##########
@@ -31,5 +31,7 @@ make prefix=/usr/local -j${NCORES} install
 
 popd
 
-# Need to remove shared library to make sure the static library is picked up by Arrow
-rm -rf re2-${RE2_VERSION}.tar.gz re2-${RE2_VERSION} /usr/local/lib/libre2.so*
+# Need to remove static library to make sure the shared library is picked up by Arrow
+# The static library fails to link when using gRPC 1.32.
+rm -rf re2-${RE2_VERSION}.tar.gz re2-${RE2_VERSION} /usr/local/lib/libre2.a

Review comment:
       Why was this changed? Manylinux builds should be all static linkage.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org