[GitHub] [spark] huaxingao commented on a diff in pull request #37025: [SPARK-39633][SQL] Fix timetravel via dataframe using timestampAsOf

[GitBox <gi...@apache.org>]

huaxingao commented on code in PR #37025:
URL: https://github.com/apache/spark/pull/37025#discussion_r910592623


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/SupportsCatalogOptionsSuite.scala:
##########
@@ -322,6 +323,12 @@ class SupportsCatalogOptionsSuite extends QueryTest with SharedSparkSession with
         timestamp = Some("2019-01-29 00:37:58")), df3.toDF())
       checkAnswer(load("t", Some(catalogName), version = None,
         timestamp = Some("2021-01-29 00:37:58")), df4.toDF())
+
+      // load with timestamp in number format
+      checkAnswer(load("t", Some(catalogName), version = None,
+        timestamp = Some(MICROSECONDS.toSeconds(ts1).toString)), df3.toDF())

Review Comment:
   I think this over: do we need to support the microsecond? Seems to me it doesn't make sense for user to specify a long value in the query
   ```
   SELECT * FROM table TIMESTAMP AS OF '1616574866666'
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org