[GitHub] [spark] zhengruifeng commented on pull request #42798: [SPARK-43295][PS] Support string type columns for `DataFrameGroupBy.sum`

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on PR #42798:
URL: https://github.com/apache/spark/pull/42798#issuecomment-1705020773

   @itholic I suspect the behavior is not deterministic: it depends on the internal order of `collect_list`
   
   To make it deterministic: I think we need to collect_list both value and index, and sort by the indices before `concat_ws`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org