[GitHub] [hive] amansinha100 commented on a change in pull request #3156: HIVE-26095: Add queryid in QueryLifeTimeHookContext

[GitBox <gi...@apache.org>]

amansinha100 commented on a change in pull request #3156:
URL: https://github.com/apache/hive/pull/3156#discussion_r838910300



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/QueryLifeTimeHookContextImpl.java
##########
@@ -78,11 +88,12 @@ public Builder withHookContext(HookContext hc) {
       return this;
     }
 
-    public QueryLifeTimeHookContextImpl build() {
+    public QueryLifeTimeHookContextImpl build(String queryId) {
       QueryLifeTimeHookContextImpl queryLifeTimeHookContext = new QueryLifeTimeHookContextImpl();
       queryLifeTimeHookContext.setHiveConf(this.conf);
       queryLifeTimeHookContext.setCommand(this.command);
       queryLifeTimeHookContext.setHookContext(this.hc);
+      queryLifeTimeHookContext.queryId = Objects.requireNonNull(queryId);

Review comment:
       Should this also check this is not an empty string and is less than max length of the query id (is there an internal constant for that ?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org