You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/18 18:45:01 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request #11705: [Doc] Fix Pulsar c++ client windows build docs
gaoran10 opened a new pull request #11705:
URL: https://github.com/apache/pulsar/pull/11705
### Motivation
Currently, docs that the Pulsar c++ client windows building-related docs are not complete.
### Modifications
Add Pulsar c++ client windows building steps in Apache Pulsar website.
Add Pulsar c++ client windows building result check section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #11705: [Doc] Fix Pulsar c++ client windows build docs
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11705:
URL: https://github.com/apache/pulsar/pull/11705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11705: [Doc] Fix Pulsar c++ client windows build docs
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11705:
URL: https://github.com/apache/pulsar/pull/11705#discussion_r691531921
##########
File path: pulsar-client-cpp/README.md
##########
@@ -235,6 +235,26 @@ ${PULSAR_PATH}/pulsar-client-cpp/cmake -DPROTOC_PATH=C:/protobuf/bin/protoc -DCM
#This will generate pulsar-cpp.sln. Open this in Visual Studio and build the desired configurations.
```
+#### Checks
+
+##### Client library will be placed in
+```
+${PULSAR_PATH}/pulsar-client-cpp/build/lib/Release/pulsar.lib
+${PULSAR_PATH}/pulsar-client-cpp/build/lib/Release/pulsar.dll
+```
+
+#### Examples
+
+##### Add windows environment paths
+```
+${PULSAR_PAHT}/pulsar-client-cpp/build/lib/Release
Review comment:
I'll fix it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on a change in pull request #11705: [Doc] Fix Pulsar c++ client windows build docs
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #11705:
URL: https://github.com/apache/pulsar/pull/11705#discussion_r691526475
##########
File path: pulsar-client-cpp/README.md
##########
@@ -235,6 +235,26 @@ ${PULSAR_PATH}/pulsar-client-cpp/cmake -DPROTOC_PATH=C:/protobuf/bin/protoc -DCM
#This will generate pulsar-cpp.sln. Open this in Visual Studio and build the desired configurations.
```
+#### Checks
+
+##### Client library will be placed in
+```
+${PULSAR_PATH}/pulsar-client-cpp/build/lib/Release/pulsar.lib
+${PULSAR_PATH}/pulsar-client-cpp/build/lib/Release/pulsar.dll
+```
+
+#### Examples
+
+##### Add windows environment paths
+```
+${PULSAR_PAHT}/pulsar-client-cpp/build/lib/Release
Review comment:
Fix path spelling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11705: [Doc] Fix Pulsar c++ client windows build docs
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11705:
URL: https://github.com/apache/pulsar/pull/11705#discussion_r691684403
##########
File path: pulsar-client-cpp/README.md
##########
@@ -235,6 +235,26 @@ ${PULSAR_PATH}/pulsar-client-cpp/cmake -DPROTOC_PATH=C:/protobuf/bin/protoc -DCM
#This will generate pulsar-cpp.sln. Open this in Visual Studio and build the desired configurations.
```
+#### Checks
+
+##### Client library will be placed in
Review comment:
```suggestion
##### Client libraries are available in the following places.
```
##########
File path: pulsar-client-cpp/README.md
##########
@@ -235,6 +235,26 @@ ${PULSAR_PATH}/pulsar-client-cpp/cmake -DPROTOC_PATH=C:/protobuf/bin/protoc -DCM
#This will generate pulsar-cpp.sln. Open this in Visual Studio and build the desired configurations.
```
+#### Checks
+
+##### Client library will be placed in
+```
+${PULSAR_PATH}/pulsar-client-cpp/build/lib/Release/pulsar.lib
+${PULSAR_PATH}/pulsar-client-cpp/build/lib/Release/pulsar.dll
+```
+
+#### Examples
+
+##### Add windows environment paths
+```
+${PULSAR_PATH}/pulsar-client-cpp/build/lib/Release
+${PULSAR_PATH}/pulsar-client-cpp/vcpkg_installed
+```
+
+##### Examples will be placed in
Review comment:
```suggestion
##### Examples are available in
```
##########
File path: site2/docs/client-libraries-cpp.md
##########
@@ -234,6 +234,37 @@ Pulsar releases are available in the [Homebrew](https://brew.sh/) core repositor
brew install libpulsar
```
+## Windows (64-bit)
+
+### Compilation
+
+1. Clone the Pulsar repository.
+
+```shell
+$ git clone https://github.com/apache/pulsar
+```
+
+2. Install all necessary dependencies.
+
+```shell
+cd ${PULSAR_HOME}/pulsar-client-cpp
+vcpkg install --feature-flags=manifests --triplet x64-windows
+```
+
+3. Build c++ libraries.
Review comment:
```suggestion
3. Build C++ libraries.
```
##########
File path: site2/docs/client-libraries-cpp.md
##########
@@ -234,6 +234,37 @@ Pulsar releases are available in the [Homebrew](https://brew.sh/) core repositor
brew install libpulsar
```
+## Windows (64-bit)
+
+### Compilation
+
+1. Clone the Pulsar repository.
+
+```shell
+$ git clone https://github.com/apache/pulsar
+```
+
+2. Install all necessary dependencies.
+
+```shell
+cd ${PULSAR_HOME}/pulsar-client-cpp
+vcpkg install --feature-flags=manifests --triplet x64-windows
+```
+
+3. Build c++ libraries.
+
+```shell
+cmake -B ./build -A x64 -DBUILD_PYTHON_WRAPPER=OFF -DBUILD_TESTS=OFF -DVCPKG_TRIPLET=x64-windows -DCMAKE_BUILD_TYPE=Release -S .
+cmake --build ./build --config Release
+```
+
+4. Client library will be placed in.
Review comment:
```suggestion
4. Client libraries are available in the following places.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11705: [Doc] Fix Pulsar c++ client windows build docs
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11705:
URL: https://github.com/apache/pulsar/pull/11705#issuecomment-902376328
Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org