You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "sunng87 (via GitHub)" <gi...@apache.org> on 2024/08/07 08:33:28 UTC
[PR] refactor: remove unneed mut for session context [datafusion]
sunng87 opened a new pull request, #11864:
URL: https://github.com/apache/datafusion/pull/11864
## Rationale for this change
Two years ago we require mutable reference of `SessionContext` for any operations like exec_*/register_*. But recently `SessionContext` owns a RwLock internally so mutable reference is no longer needed.
## What changes are included in this PR?
This change remove all mutable marker I can find in tests, docs and also one API of `SessionContext`
This change
## Are these changes tested?
When it compiles, it's correct.
## Are there any user-facing changes?
There is an API breaking change for `register_catalog_list` in `SessionContext`. The mutable requirement is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: remove unneed mut for session context [datafusion]
Posted by "lewiszlw (via GitHub)" <gi...@apache.org>.
lewiszlw merged PR #11864:
URL: https://github.com/apache/datafusion/pull/11864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org