You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/02 09:48:05 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
davidjumani opened a new pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373
This adds the option to create PVLAN for L2 networks, as well as fixes the issue caused by passing 'none' as the PVLAN type when no secondary VLAN type is selected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-647947957
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-2087)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645930099
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-647928599
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-638073542
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. JID-1959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-647854543
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-647940981
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-648567047
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-2106)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645771629
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-2040)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-640358256
Does it cover all cases for https://github.com/apache/cloudstack/pull/3732 ? @davidjumani ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-638069426
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645941149
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-2052)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-639257464
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645929499
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-648559283
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-640362902
@rhtyd Yes it does!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-638068751
@borisstoyanov @vladimirpetrov - please ping me once you confirm testing the feature
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-648559692
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-647926039
@davidjumani can you check and fix label on L2 form? (label.promiscuous)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645765398
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645942243
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645936981
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-639259874
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-1967)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#discussion_r439348341
##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -109,6 +109,32 @@
<a-form-item :label="$t('label.bypassvlanoverlapcheck')" v-if="!this.isObjectEmpty(this.selectedNetworkOffering) && this.selectedNetworkOffering.specifyvlan">
<a-switch v-decorator="['bypassvlanoverlapcheck']" />
</a-form-item>
+ <a-form-item :label="$t('label.isolatedpvlantype')" v-if="!this.isObjectEmpty(this.selectedNetworkOffering) && this.selectedNetworkOffering.specifyvlan">
+ <a-radio-group
+ v-decorator="['isolatedpvlantype', {
+ initialValue: this.isolatePvlanType
+ }]"
+ buttonStyle="solid"
+ @change="selected => { this.handleIsolatedPvlanTypeChange(selected.target.value) }">
Review comment:
minor: can be simplified
```suggestion
@change="selected => { this.isolatePvlanType = selected.target.value }">
```
##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -228,6 +255,9 @@ export default {
this.selectedZone = zone
this.updateVPCCheckAndFetchNetworkOfferingData()
},
+ handleIsolatedPvlanTypeChange (pvlan) {
+ this.isolatePvlanType = pvlan
+ },
Review comment:
```suggestion
```
##########
File path: src/views/network/CreateSharedNetworkForm.vue
##########
@@ -589,11 +589,11 @@ export default {
if (this.isValidValueForKey(values, 'bypassvlanoverlapcheck')) {
params.bypassvlanoverlapcheck = values.bypassvlanoverlapcheck
}
- if (this.isValidValueForKey(values, 'isolatedpvlantype')) {
+ if (this.isValidValueForKey(values, 'isolatedpvlantype') && values.isolatedpvlantype !== 'none') {
params.isolatedpvlantype = values.isolatedpvlantype
- }
- if (this.isValidValueForKey(values, 'isolatedpvlan')) {
- params.isolatedpvlan = values.isolatedpvlan
+ if (this.isValidValueForKey(values, 'isolatedpvlan')) {
+ params.isolatedpvlan = values.isolatedpvlan
+ }
Review comment:
Not sure if this really needs to go inside `isolatedpvlantype` if block. Anyway we are not showing `isolatedpvlan` field for `none` type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#discussion_r439469614
##########
File path: src/views/network/CreateSharedNetworkForm.vue
##########
@@ -589,11 +589,11 @@ export default {
if (this.isValidValueForKey(values, 'bypassvlanoverlapcheck')) {
params.bypassvlanoverlapcheck = values.bypassvlanoverlapcheck
}
- if (this.isValidValueForKey(values, 'isolatedpvlantype')) {
+ if (this.isValidValueForKey(values, 'isolatedpvlantype') && values.isolatedpvlantype !== 'none') {
params.isolatedpvlantype = values.isolatedpvlantype
- }
- if (this.isValidValueForKey(values, 'isolatedpvlan')) {
- params.isolatedpvlan = values.isolatedpvlan
+ if (this.isValidValueForKey(values, 'isolatedpvlan')) {
+ params.isolatedpvlan = values.isolatedpvlan
+ }
Review comment:
so we're verifying it only if the pvlan type is not none
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645942521
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-642632645
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645945677
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-2053)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#discussion_r444666360
##########
File path: src/views/network/CreateL2NetworkForm.vue
##########
@@ -164,7 +190,8 @@ export default {
networkOfferings: [],
networkOfferingLoading: false,
selectedNetworkOffering: {},
- accountVisible: this.isAdminOrDomainAdmin()
+ accountVisible: this.isAdminOrDomainAdmin(),
Review comment:
@davidjumani did you check against legacy UI if we should show pvlan options to domain admins?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645936401
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-639257805
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #373: Adding pvlan option for l2 and fixing passing none for no pvlan type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #373:
URL: https://github.com/apache/cloudstack-primate/pull/373#issuecomment-645934220
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/373 (JID-2050)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org