You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/09/04 16:12:32 UTC
[GitHub] qpid-dispatch pull request #371: DISPATCH-1090 - Draim excess credit if ther...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/371
DISPATCH-1090 - Draim excess credit if there are no receivers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1090-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #371
----
commit 18fbf5b9ad73069bf00f09da537c34511aa6b2f0
Author: Ganesh Murthy <gm...@...>
Date: 2018-08-28T19:09:16Z
DISPATCH-1090 - Draim excess credit if there are no receivers
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #371: DISPATCH-1090 - Draim excess credit if there are n...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on the issue:
https://github.com/apache/qpid-dispatch/pull/371
Fixed "Draim" to "Drain". Thanks for testing.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #371: DISPATCH-1090 - Draim excess credit if there are n...
Posted by k-wall <gi...@git.apache.org>.
Github user k-wall commented on the issue:
https://github.com/apache/qpid-dispatch/pull/371
I manually tested the patch https://github.com/apache/qpid-dispatch/pull/371 against Artemis 2.6.2, Broker-J 7.0.6 and CPP Broker (master). The new behaviour looks good to me.
btw. There's a typo in the commit message "Draim" rather than "Drain".
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #371: DISPATCH-1090 - Draim excess credit if ther...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/371
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #371: DISPATCH-1090 - Draim excess credit if there are n...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/371
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/371?src=pr&el=h1) Report
> Merging [#371](https://codecov.io/gh/apache/qpid-dispatch/pull/371?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/f0e15f82f577ac5bb86e377a7711da2a3ff73767?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/371?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 84.8% 84.85% +0.05%
==========================================
Files 70 70
Lines 16001 16002 +1
==========================================
+ Hits 13569 13578 +9
+ Misses 2432 2424 -8
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/371?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/371/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.57% <100%> (+0.47%)` | :arrow_up: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/371/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.74% <0%> (+0.19%)` | :arrow_up: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/371/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.09% <0%> (+0.21%)` | :arrow_up: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/371/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.87% <0%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/371?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/371?src=pr&el=footer). Last update [f0e15f8...18fbf5b](https://codecov.io/gh/apache/qpid-dispatch/pull/371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org